HDDS-1527. HDDS Datanode start fails due to datanode.id file read error

[swagle]

The modification here is to load id file as yaml and if that fails, log the exception and load as protobuf.
The case where yaml file is corrupted, we would still throw an exception after trying to load protobuf with the error in the log file.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	32	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	421	trunk passed
+1	compile	203	trunk passed
+1	checkstyle	56	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	826	branch has no errors when building and testing our client artifacts.
+1	javadoc	129	trunk passed
0	spotbugs	235	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	418	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	396	the patch passed
+1	compile	210	the patch passed
+1	javac	210	the patch passed
+1	checkstyle	61	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	657	patch has no errors when building and testing our client artifacts.
+1	javadoc	124	the patch passed
+1	findbugs	428	the patch passed
		_ Other Tests _
-1	unit	140	hadoop-hdds in the patch failed.
-1	unit	1105	hadoop-ozone in the patch failed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		5375

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerCommandHandler
	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-822/1/artifact/out/Dockerfile
GITHUB PR	#822
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 30d6347eeaad 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 77170e7
Default Java	1.8.0_191
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-822/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-822/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-822/1/testReport/
Max. process+thread count	5289 (vs. ulimit of 5500)
modules	C: hadoop-hdds/container-service U: hadoop-hdds/container-service
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-822/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[swagle]

Unit test failures are unrelated. @arp7 Can you review this change, please?

[xiaoyuyao]

LGTM.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1388	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	67	Maven dependency ordering for branch
+1	mvninstall	479	trunk passed
+1	compile	217	trunk passed
+1	checkstyle	55	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	918	branch has no errors when building and testing our client artifacts.
+1	javadoc	126	trunk passed
0	spotbugs	247	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	438	trunk passed
		_ Patch Compile Tests _
0	mvndep	24	Maven dependency ordering for patch
+1	mvninstall	411	the patch passed
+1	compile	206	the patch passed
+1	javac	206	the patch passed
+1	checkstyle	56	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	699	patch has no errors when building and testing our client artifacts.
+1	javadoc	122	the patch passed
+1	findbugs	440	the patch passed
		_ Other Tests _
-1	unit	167	hadoop-hdds in the patch failed.
-1	unit	1389	hadoop-ozone in the patch failed.
+1	asflicense	35	The patch does not generate ASF License warnings.
		7399

Reason	Tests
Failed junit tests	hadoop.ozone.container.TestContainerReplication

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-822/2/artifact/out/Dockerfile
GITHUB PR	#822
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 38c47291400f 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / de01422
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-822/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-822/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-822/2/testReport/
Max. process+thread count	5387 (vs. ulimit of 5500)
modules	C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-822/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[xiaoyuyao]

+1, Thanks @swagle for the contribution.