Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-16328: ClassCastException in S3GuardTool.checkMetadataStoreUri #849

Closed
wants to merge 1 commit into from
Closed

HADOOP-16328: ClassCastException in S3GuardTool.checkMetadataStoreUri #849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 12 additions & 2 deletions hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3GuardTool.java
View file
Open in desktop
Expand Up @@ -236,8 +236,18 @@ protected void checkIfS3BucketIsGuarded(List<String> paths)
if(metadataStoreUri == null || metadataStoreUri.isEmpty()) {
// If not set, check if filesystem is guarded by creating an
// S3AFileSystem and check if hasMetadataStore is true
try (S3AFileSystem s3AFileSystem = (S3AFileSystem)
S3AFileSystem.newInstance(toUri(s3Path), getConf())){
URI uri = toUri(s3Path);
FileSystem fs = FileSystem.newInstance(uri, getConf());
if (!(fs instanceof S3AFileSystem)) {
// this issue has surfaced in tests (HADOOP-16328),
// so print a full stack trace out before failing.
String msg = "Filesystem for " + uri
+ " must be an S3AFilesytem, but got a "
+ fs.getClass();
LOG.error("{}: {}", msg, fs);
throw new ExitUtil.ExitException(EXIT_BAD_CONFIGURATION, msg);
}
try (S3AFileSystem s3AFileSystem = (S3AFileSystem) fs) {
Preconditions.checkState(s3AFileSystem.hasMetadataStore(),
"The S3 bucket is unguarded. " + getName()
+ " can not be used on an unguarded bucket.");
Expand Down