HDDS-1568 : Add RocksDB metrics to OM. #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label ozone |
|
💔 -1 overall
This message was automatically generated. |
anuengineer
reviewed
May 29, 2019
| @@ -41,13 +49,21 @@ | |||
| /** | |||
| * Adapter JMX bean to publish all the Rocksdb metrics. | |||
| */ | |||
| public class RocksDBStoreMBean implements DynamicMBean { | |||
| public class RocksDBStoreMBean implements DynamicMBean, MetricsSource { | |||
|
|
|||
There was a problem hiding this comment.
@anuengineer I verified by checking the /prom servlet end point. I also made changes in the prometheus sink metric name sanitization code so that the RocksDB metric names don't look odd.
| option = dbProfile.getDBOptions(); | ||
| } | ||
|
|
||
| if (!rocksDbStat.equals(OZONE_METADATA_STORE_ROCKSDB_STATISTICS_OFF)) { |
There was a problem hiding this comment.
There is some history here. During our first release we found that RocksDB is also shipped by YARN. That version of RocksDB is very old, hence this call would fail in mysterious ways. @arp7 went and fixed that issue and made sure that we don't enable this by default. I am fine with enabling this, if we don't run into that old issue again. @elek, @arp7 any comments ?
There was a problem hiding this comment.
@anuengineer We don't enable the metrics by default. I just used the same config that is used to enable metrics for SCM RocksDB, to enable metrics for OM RocksDB as well.
There was a problem hiding this comment.
I am not familiar with the old issue, but now our classpath is separated from yarn. We can use any newer rocksdb (but we should use the same versions for all the hdds/ozone projects)
I think it's safe to use any new rocksdb feature if you think metrics should be turned on by default...
|
💔 -1 overall
This message was automatically generated. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Causing Travis-CI builds to appear broken on master. Author: Daniel Nishimura <dnishimura@linkedin.com> Reviewers: Prateek Maheshwari <pmaheshwari@apache.org> Closes apache#868 from dnishimura/disable-sonar-scanner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RocksDB statistics need to sinked to hadoop-metrics2 for Ozone Manager to understand how OM behaves under heavy load.
Example: "rocksdb.bytes.written"