New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-1540. Implement addAcl,removeAcl,setAcl,getAcl for Bucket. Contributed by Ajay Kumar. #874
Conversation
…ibuted by Ajay Kumar. (cherry picked from commit 7fc904ca01a281365c89638e8badd7c528c225b0)
💔 -1 overall
This message was automatically generated. |
Test failures are unrelated. |
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
Show resolved
Hide resolved
.setAcls(list) | ||
.build(); | ||
|
||
metadataManager.getBucketTable().put(dbBucketKey, updatedBucket); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local DB put may not work with OM HA. cc: @bharatviswa504 for additional comments on the proper way to commit OM metadata changes via Ratis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes in HA path, we shall not do table put, we will use cache and double buffer.
For reference, have a look into HDDS-1551.
I have opened HDDS-1618 to use the newly added code for HA/Non-HA. As this is newly implemented OM request, it can follow the new approach, so that we can avoid refactoring again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a todo to handle this. jira is [HDDS-1619].
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ajayydv for the patch. Comments are added inline.
Please also add unit tests for the new code. Thanks!
💔 -1 overall
This message was automatically generated. |
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/IOzoneAcl.java
Outdated
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, pending CI.
💔 -1 overall
This message was automatically generated. |
SAMZA-2058: Integrate the input stream expansion aware SystemStreamGrouper to JobModel generation flow.
No description provided.