HADOOP-16341. ShutDownHookManager: Regressed performance on Hook remo… #940

t3rmin4t0r · 2019-06-10T22:11:35Z

…vals after HADOOP-15679

hadoop-yetus · 2019-06-11T00:14:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	904	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1143	trunk passed
+1	compile	1152	trunk passed
+1	checkstyle	36	trunk passed
+1	mvnsite	78	trunk passed
+1	shadedclient	777	branch has no errors when building and testing our client artifacts.
+1	javadoc	63	trunk passed
0	spotbugs	126	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	124	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	52	the patch passed
+1	compile	1225	the patch passed
+1	javac	1225	the patch passed
-0	checkstyle	43	hadoop-common-project/hadoop-common: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
+1	mvnsite	76	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	747	patch has no errors when building and testing our client artifacts.
+1	javadoc	66	the patch passed
+1	findbugs	148	the patch passed
		_ Other Tests _
-1	unit	552	hadoop-common in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		7296

Reason	Tests
Failed junit tests	hadoop.fs.viewfs.TestViewFsTrash

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-940/1/artifact/out/Dockerfile
GITHUB PR	#940
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 2814f2c826df 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `9191e08`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-940/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-940/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-940/1/testReport/
Max. process+thread count	1386 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-940/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-13T00:17:28Z

...p-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ShutdownHookManager.java

-    return hooks.remove(new HookEntry(shutdownHook, 0));
+    // hooks are only == by runnable
+    return hooks.remove(new HookEntry(shutdownHook, 0, TIMEOUT_MINIMUM,
+	        TIME_UNIT_DEFAULT));


whitespace:tabs in line

hadoop-yetus · 2019-06-13T00:17:30Z

...p-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ShutdownHookManager.java

-    return hooks.contains(new HookEntry(shutdownHook, 0));
+    // hooks are only == by runnable
+    return hooks.remove(new HookEntry(shutdownHook, 0, TIMEOUT_MINIMUM,
+	        TIME_UNIT_DEFAULT));


whitespace:tabs in line

hadoop-yetus · 2019-06-13T00:17:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	49	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1137	trunk passed
+1	compile	1086	trunk passed
+1	checkstyle	44	trunk passed
+1	mvnsite	76	trunk passed
+1	shadedclient	868	branch has no errors when building and testing our client artifacts.
+1	javadoc	62	trunk passed
0	spotbugs	121	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	120	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	46	the patch passed
+1	compile	1142	the patch passed
+1	javac	1142	the patch passed
-0	checkstyle	43	hadoop-common-project/hadoop-common: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1	mvnsite	78	the patch passed
-1	whitespace	0	The patch 2 line(s) with tabs.
+1	shadedclient	704	patch has no errors when building and testing our client artifacts.
+1	javadoc	63	the patch passed
+1	findbugs	142	the patch passed
		_ Other Tests _
-1	unit	516	hadoop-common in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		6299

Reason	Tests
Failed junit tests	hadoop.util.TestShutdownHookManager

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-940/2/artifact/out/Dockerfile
GITHUB PR	#940
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux aa36073be14b 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `205dd2d`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-940/2/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-940/2/artifact/out/whitespace-tabs.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-940/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-940/2/testReport/
Max. process+thread count	1381 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-940/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-13T03:49:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	52	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1179	trunk passed
+1	compile	1531	trunk passed
+1	checkstyle	48	trunk passed
+1	mvnsite	96	trunk passed
+1	shadedclient	877	branch has no errors when building and testing our client artifacts.
+1	javadoc	67	trunk passed
0	spotbugs	151	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	148	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	60	the patch passed
+1	compile	1512	the patch passed
+1	javac	1512	the patch passed
+1	checkstyle	45	the patch passed
+1	mvnsite	84	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	752	patch has no errors when building and testing our client artifacts.
+1	javadoc	71	the patch passed
+1	findbugs	156	the patch passed
		_ Other Tests _
-1	unit	628	hadoop-common in the patch failed.
+1	asflicense	51	The patch does not generate ASF License warnings.
		7423

Reason	Tests
Failed junit tests	hadoop.util.TestShutdownHookManager

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-940/3/artifact/out/Dockerfile
GITHUB PR	#940
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux e8ea86454f9c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `88c53d5`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-940/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-940/3/testReport/
Max. process+thread count	1388 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-940/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

zeroflag · 2019-07-12T08:34:19Z

retest this please

HADOOP-16341. ShutDownHookManager: Regressed performance on Hook remo…

1799a47

…vals after HADOOP-15679

Fix the checkstyle issue

8252370

hadoop-yetus reviewed Jun 13, 2019

View reviewed changes

Fix the ws issue

82f7342

zeroflag mentioned this pull request Jul 12, 2019

HADOOP-16341. ShutDownHookManager: Regressed performance on Hook removals after HADOOP-15679 #1086

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-16341. ShutDownHookManager: Regressed performance on Hook remo… #940

HADOOP-16341. ShutDownHookManager: Regressed performance on Hook remo… #940

t3rmin4t0r commented Jun 10, 2019

hadoop-yetus commented Jun 11, 2019

hadoop-yetus Jun 13, 2019

hadoop-yetus Jun 13, 2019

hadoop-yetus commented Jun 13, 2019

hadoop-yetus commented Jun 13, 2019

zeroflag commented Jul 12, 2019

HADOOP-16341. ShutDownHookManager: Regressed performance on Hook remo… #940

Are you sure you want to change the base?

HADOOP-16341. ShutDownHookManager: Regressed performance on Hook remo… #940

Conversation

t3rmin4t0r commented Jun 10, 2019

hadoop-yetus commented Jun 11, 2019

hadoop-yetus Jun 13, 2019

Choose a reason for hiding this comment

hadoop-yetus Jun 13, 2019

Choose a reason for hiding this comment

hadoop-yetus commented Jun 13, 2019

hadoop-yetus commented Jun 13, 2019

zeroflag commented Jul 12, 2019