HADOOP-16379: S3AInputStream#unbuffer should merge input stream stats into fs-wide stats #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AUnbuffer.java
Outdated
Show resolved
Hide resolved
| inputStream = fs.open(dest); | ||
|
|
||
| // Sanity check to make sure the stream statistics are 0 | ||
| assertEquals(0, |
There was a problem hiding this comment.
use org.apache.hadoop.fs.s3a.S3ATestUtils.MetricDiff for measuring and asserting on state of metrics, as it generates meaningful error messages on assert failures.
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AUnbuffer.java
Outdated
Show resolved
Hide resolved
| public void setup() throws Exception { | ||
| super.setup(); | ||
| dest = path("ITestS3AUnbuffer"); | ||
| describe("ITestS3AUnbuffer"); | ||
| try (FSDataOutputStream outputStream = getFileSystem().create(dest, true)) { |
There was a problem hiding this comment.
ContractTestUtils.writeDataset
| // instance of S3AInstrumentation | ||
| Configuration conf = createConfiguration(); | ||
| S3AFileSystem fs = new S3AFileSystem(); | ||
| fs.initialize(getFileSystem().getUri(), conf); |
There was a problem hiding this comment.
needs to be deleted in a finally clause
Also, I don't think it is needed at all. MetricDiff is designed to do asserts over changes in statistics.
|
|
||
| @Override | ||
| public void teardown() throws Exception { | ||
| getFileSystem().delete(dest, true); |
There was a problem hiding this comment.
superclass deleteTestDirInTeardown() should do this. If it doesn't, guard the call with checks for filesystem and destpath not being null, so it won't hide the stack traces of a failure in setup
|
LGTM, some changes around the testing. Checkstyle has a complaint which needs to be addressed |
… into fs-wide stats
sahilTakiar
force-pushed
the
HADOOP-16379
branch
from
6ef1aed
to
1928b33
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
@steveloughran addressed your comments. Hadoop QA looks happy as well. Re-ran the S3A tests. |
|
LGTM: +1 |
|
committed to trunk. thanks! |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HADOOP-16379: S3AInputStream#unbuffer should merge input stream stats into fs-wide stats
InputStreamStatisticscalledmergewhich allows users to periodically merge the stats into the fs-wide statsunbuffermerges the stream stats into the fs-wide statsTesting: