Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27488 [hbase-connectors] Duplicate result when searching HBase by Spark #106

Merged
merged 4 commits into from Aug 2, 2023
Merged

HBASE-27488 [hbase-connectors] Duplicate result when searching HBase by Spark #106

merged 4 commits into from Aug 2, 2023

Conversation

ILuffZhe
Copy link
Contributor

@ILuffZhe ILuffZhe commented Nov 19, 2022 •
edited

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 1m 26s master passed
+1 💚 compile 0m 40s master passed
+1 💚 scaladoc 0m 49s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 50s the patch passed
+1 💚 compile 0m 39s the patch passed
+1 💚 scalac 0m 39s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 scaladoc 0m 49s the patch passed
_ Other Tests _
+1 💚 unit 8m 6s hbase-spark in the patch passed.
16m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #106
Optional Tests dupname scalac scaladoc unit compile
uname Linux 362823b827c4 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 496cd58
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/1/testReport/
Max. process+thread count 918 (vs. ulimit of 12500)
modules C: spark/hbase-spark U: spark/hbase-spark
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/1/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Reidddddd Reidddddd self-requested a review August 2, 2023 08:17
Reidddddd
Reidddddd approved these changes Aug 2, 2023
View reviewed changes
Copy link

@Reidddddd Reidddddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Reidddddd
Copy link

waiting for QA

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 1m 52s master passed
+1 💚 compile 0m 59s master passed
+1 💚 scaladoc 1m 13s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 12s the patch passed
+1 💚 compile 1m 3s the patch passed
+1 💚 scalac 1m 3s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 scaladoc 1m 29s the patch passed
_ Other Tests _
-1 ❌ unit 6m 31s hbase-spark in the patch failed.
17m 20s
Reason Tests
Failed junit tests hadoop.hbase.spark.DefaultSourceSuite
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #106
Optional Tests dupname scalac scaladoc unit compile
uname Linux 5a8ddaf30629 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 5d56e16
unit https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/2/artifact/yetus-precommit-check/output/patch-unit-spark_hbase-spark.txt
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/2/testReport/
Max. process+thread count 953 (vs. ulimit of 12500)
modules C: spark/hbase-spark U: spark/hbase-spark
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/2/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 1m 57s master passed
+1 💚 compile 0m 58s master passed
+1 💚 scaladoc 1m 17s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 22s the patch passed
+1 💚 compile 1m 18s the patch passed
+1 💚 scalac 1m 18s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 scaladoc 1m 35s the patch passed
_ Other Tests _
-1 ❌ unit 6m 8s hbase-spark in the patch failed.
16m 34s
Reason Tests
Failed junit tests hadoop.hbase.spark.DefaultSourceSuite
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/3/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #106
Optional Tests dupname scalac scaladoc unit compile
uname Linux 0ed15b02c145 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 5d56e16
unit https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/3/artifact/yetus-precommit-check/output/patch-unit-spark_hbase-spark.txt
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/3/testReport/
Max. process+thread count 955 (vs. ulimit of 12500)
modules C: spark/hbase-spark U: spark/hbase-spark
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/3/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Reidddddd
Copy link

Reason Tests
Failed junit tests hadoop.hbase.spark.DefaultSourceSuite

@ILuffZhe please help check if it is related

@ILuffZhe
Copy link
Contributor Author

ILuffZhe commented Aug 2, 2023

Reason Tests
Failed junit tests hadoop.hbase.spark.DefaultSourceSuite
@ILuffZhe please help check if it is related

Sure, I'm already on it.

@ILuffZhe
Copy link
Contributor Author

ILuffZhe commented Aug 2, 2023 •
edited

@Reidddddd In this test case, we have duplicate rowkey filter, so the expression should be KEY_FIELD == 0 OR KEY_FIELD == 1 instead of ( ( KEY_FIELD == 0 OR KEY_FIELD == 1 ) OR KEY_FIELD == 2 ).

@ILuffZhe ILuffZhe requested a review from Reidddddd August 2, 2023 10:53
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 43s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 1m 58s master passed
+1 💚 compile 1m 9s master passed
+1 💚 scaladoc 1m 20s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 21s the patch passed
+1 💚 compile 1m 4s the patch passed
+1 💚 scalac 1m 4s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 scaladoc 1m 22s the patch passed
_ Other Tests _
+1 💚 unit 10m 14s hbase-spark in the patch passed.
20m 18s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/4/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #106
Optional Tests dupname scalac scaladoc unit compile
uname Linux 0eae2080e5be 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 5d56e16
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/4/testReport/
Max. process+thread count 959 (vs. ulimit of 12500)
modules C: spark/hbase-spark U: spark/hbase-spark
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-106/4/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Reidddddd Reidddddd merged commit f8ee8f6 into apache:master Aug 2, 2023
1 check passed
subrat-mishra pushed a commit to subrat-mishra/hbase-connectors that referenced this pull request Aug 8, 2023
@ILuffZhe @subrat-mishra
HBASE-27488 [hbase-connectors] Duplicate result when searching HBase …
aba779d 
…by Spark (apache#106)

Signed-off-by: Reid Chan <reidchan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reidddddd Reidddddd Awaiting requested review from Reidddddd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ILuffZhe @Apache-HBase @Reidddddd