HBASE-27042. Remove S3Guard awareness from HBoss #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cut HBoss test code which would explicitly disable S3Guard -obsolete and breaks the build on forthcoming hadoop releases. * Also cut all references in docs and XML. * EmbeddedS3 to implement deleteObject() and so support AWS SDKs 1.11.1026+, which expects this (hadoop 3.3.2+). * Maven test runs to provide full stack traces on failures, so runtime failures can be debugged and fixed. Change-Id: Iab10cfc6780cea064ea116efc1c177332d780514
|
tested in the mock client, and in progress is a test with fs.hboss.data.uri pointing at a real s3a bucket. not convinced that this setting is being picked up though. |
|
(yes, it was being picked up, adding an invalid bucket triggered test run). bulild options were |
|
s3 london; directory markers=keep Tests run: 225, Failures: 0, Errors: 0, Skipped: 55 |
joshelser
approved these changes
May 23, 2022
|
Running the tests locally since we don't have QA wired up here automatically. Edit - All of these passed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-obsolete and breaks the build on forthcoming hadoop releases.
AWS SDKs 1.11.1026+, which expects this (hadoop 3.3.2+).
so runtime failures can be debugged and fixed.