HBASE-24559: Fix test logging initialization #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshelser @phrocker FYI |
|
Rebased on top of my other patches. Had to make some small fixes to get the tests running. |
phrocker
approved these changes
Jun 19, 2020
src/hbase/test-util/test-util.cc
Outdated
| namespace hbase { | ||
| string TestUtil::get_exec_path() { | ||
| char result[ PATH_MAX ]; | ||
| ssize_t count = readlink( "/proc/self/exe", result, PATH_MAX ); |
There was a problem hiding this comment.
Not sure if we can use boost::dll::program_location ( that's 1.61 + I think ) but that may be more cross platform compatible.
There was a problem hiding this comment.
Good point, I missed it, thanks. Switched to boost::dll::program_location for now and enforced min version to 1.6.1. That should be ok I guess
1. Moved test-util/* to mini-cluster-util* 2. Implement a macro that is to be used by all tests. The macro adds the initialization that can be exploited by all the unit tests 3. Misc fixes for classpath resolution. 4. Enforces boost min version to 1.6.1 for using boost::dll::program_location Ex: GLOG_logtostderr=1 ./async-batch-rpc-test // logs to stderr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split into two commits
the initialization that can be exploited by all the unit tests
Ex: GLOG_logtostderr=1 ./async-batch-rpc-test...