Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-28057 Run spotless:apply and fix any existing spotless issues #137

Merged
merged 2 commits into from Aug 31, 2023
Merged

HBASE-28057 Run spotless:apply and fix any existing spotless issues #137

merged 2 commits into from Aug 31, 2023

Conversation

NihalJain
Copy link
Contributor

No description provided.

@NihalJain NihalJain mentioned this pull request Aug 31, 2023
Merged
@NihalJain NihalJain requested a review from Apache9 August 31, 2023 13:44
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 spotbugs 0m 0s spotbugs executables are not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 0m 48s master passed
+1 💚 compile 0m 9s master passed
+1 💚 checkstyle 0m 8s master passed
+1 💚 javadoc 0m 7s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 11s the patch passed
+1 💚 compile 0m 10s the patch passed
+1 💚 javac 0m 10s the patch passed
+1 💚 checkstyle 0m 4s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 5s the patch passed
_ Other Tests _
+1 💚 unit 4m 36s hbase-hbck2 in the patch passed.
+1 💚 asflicense 0m 6s The patch does not generate ASF License warnings.
7m 55s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-137/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #137
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 8da7bcc01db7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool maven
git revision master / 0bf6ee1
Default Java Oracle Corporation-1.8.0_342-b07
Test Results https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-137/1/testReport/
Max. process+thread count 1257 (vs. ulimit of 5000)
modules C: hbase-hbck2 U: hbase-hbck2
Console output https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-137/1/console
versions git=2.30.2 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 reviewed Aug 31, 2023
View reviewed changes
hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java Outdated
@@ -613,8 +613,7 @@ private static String getCommandUsage() {

private static void usageAddFsRegionsMissingInMeta(PrintWriter writer) {
writer.println(" " + ADD_MISSING_REGIONS_IN_META_FOR_TABLES + " [OPTIONS]");
writer.println(" [<NAMESPACE|"
+ "NAMESPACE:TABLENAME>...|-i <INPUTFILES>...]");
writer.println(" [<NAMESPACE|" + "NAMESPACE:TABLENAME>...|-i <INPUTFILES>...]");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we could just remove the '+' operator?

hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java Outdated
@@ -767,8 +766,7 @@ private static void usageReplication(PrintWriter writer) {
}

private static void usageExtraRegionsInMeta(PrintWriter writer) {
writer.println(" " + EXTRA_REGIONS_IN_META + " [<NAMESPACE|"
+ "NAMESPACE:TABLENAME>...|");
writer.println(" " + EXTRA_REGIONS_IN_META + " [<NAMESPACE|" + "NAMESPACE:TABLENAME>...|");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java Outdated
writer.println(" " + REPORT_MISSING_REGIONS_IN_META + " [<NAMESPACE|"
+ "NAMESPACE:TABLENAME>...|");
writer
.println(" " + REPORT_MISSING_REGIONS_IN_META + " [<NAMESPACE|" + "NAMESPACE:TABLENAME>...|");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto. At least we could remove the last '+'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Let me fix these.

@NihalJain
Copy link
Contributor Author

Updated PR!

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 spotbugs 0m 0s spotbugs executables are not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 0m 49s master passed
+1 💚 compile 0m 10s master passed
+1 💚 checkstyle 0m 7s master passed
+1 💚 javadoc 0m 7s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 10s the patch passed
+1 💚 compile 0m 9s the patch passed
+1 💚 javac 0m 9s the patch passed
+1 💚 checkstyle 0m 5s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 5s the patch passed
_ Other Tests _
+1 💚 unit 4m 38s hbase-hbck2 in the patch passed.
+1 💚 asflicense 0m 6s The patch does not generate ASF License warnings.
7m 6s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-137/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #137
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 8b12821a9e0d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool maven
git revision master / 0bf6ee1
Default Java Oracle Corporation-1.8.0_342-b07
Test Results https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-137/2/testReport/
Max. process+thread count 1282 (vs. ulimit of 5000)
modules C: hbase-hbck2 U: hbase-hbck2
Console output https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-137/2/console
versions git=2.30.2 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain NihalJain requested a review from Apache9 August 31, 2023 14:59
@NihalJain NihalJain merged commit ffef531 into apache:master Aug 31, 2023
1 check passed
@NihalJain
Copy link
Contributor Author

Thank you @petersomogyi and @Apache9 for the reviews. Merged the changes!

@NihalJain NihalJain mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersomogyi petersomogyi petersomogyi approved these changes

@Apache9 Apache9 Awaiting requested review from Apache9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@NihalJain @Apache-HBase @petersomogyi @Apache9