Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28381 Support building hbase-operator-tools with JDK17 #141

Merged
merged 1 commit into from Mar 4, 2024

Conversation

NihalJain
Copy link
Contributor

No description provided.

@NihalJain NihalJain changed the title HBASE-28381 Build hbase-operator-tools with JDK17 HBASE-28381 Allow building hbase-operator-tools with JDK17 Feb 28, 2024
@NihalJain NihalJain changed the title HBASE-28381 Allow building hbase-operator-tools with JDK17 HBASE-28381 Support building hbase-operator-tools with JDK17 Feb 28, 2024
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 0m 53s master passed
+1 💚 compile 0m 12s master passed
+1 💚 spotless 0m 8s branch has no errors when running spotless:check.
+1 💚 javadoc 0m 9s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 19s the patch passed
+1 💚 compile 0m 12s the patch passed
+1 💚 javac 0m 12s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 spotless 0m 5s patch has no errors when running spotless:check.
+1 💚 javadoc 0m 6s the patch passed
_ Other Tests _
+1 💚 unit 6m 15s root in the patch passed.
+1 💚 asflicense 0m 7s The patch does not generate ASF License warnings.
10m 20s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-141/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #141
Optional Tests dupname asflicense javac javadoc unit spotless xml compile
uname Linux 1331a282228c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 557fd6e
Default Java Oracle Corporation-1.8.0_342-b07
Test Results https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-141/1/testReport/
Max. process+thread count 1280 (vs. ulimit of 5000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-141/1/console
versions git=2.30.2 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 0m 46s master passed
+1 💚 compile 0m 10s master passed
+1 💚 spotless 0m 7s branch has no errors when running spotless:check.
+1 💚 javadoc 0m 8s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 18s the patch passed
+1 💚 compile 0m 11s the patch passed
+1 💚 javac 0m 11s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 0s The patch has no ill-formed XML file.
+1 💚 spotless 0m 5s patch has no errors when running spotless:check.
+1 💚 javadoc 0m 6s the patch passed
_ Other Tests _
+1 💚 unit 6m 18s root in the patch passed.
+1 💚 asflicense 0m 6s The patch does not generate ASF License warnings.
8m 56s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-141/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #141
Optional Tests dupname asflicense javac javadoc unit spotless xml compile
uname Linux 0434449637db 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 557fd6e
Default Java Oracle Corporation-1.8.0_342-b07
Test Results https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-141/2/testReport/
Max. process+thread count 1283 (vs. ulimit of 5000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-141/2/console
versions git=2.30.2 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
Copy link
Contributor Author

Added support to build against JDK11, JDK17 here while making sure we can still build with JDK8. The flags are added as tests fail without them.
Tested locally by running with profile -Pbuild-with-jdk17 on JDK17

Can add another task to update precommit to build with JDK17, if others feel it will be useful.? Please LMK WDYT?

CC: @wchevreuil @petersomogyi @Apache9

Copy link

@chrajeshbabu chrajeshbabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm

@NihalJain
Copy link
Contributor Author

Lets see if we can get any more reviews by EOD. Otherwise will merge this to codebase later tonight.

Copy link
Contributor

@petersomogyi petersomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NihalJain NihalJain merged commit 4286235 into apache:master Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants