HBASE-24571 HBCK2 fix addFsRegionsMissingInMeta to add regions in CLO… #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchevreuil
requested review from
joshelser,
brfrn169,
petersomogyi,
jatsakthi and
virajjasani
|
The failure is not related to this commit. It seems the test added in HBASE-23927 is creating an inputForAssignsTest file under project root dir, which causes asflicense checks to fail: https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/175/artifact/patchprocess/patch-asflicense-problems.txt. |
|
retest build |
virajjasani
approved these changes
Jun 17, 2020
| @@ -454,6 +457,18 @@ public static Put makePutFromRegionInfo(RegionInfo region, long ts) throws IOExc | |||
| return put; | |||
| } | |||
|
|
|||
| private static Put addRegionStateToPut(Put put, RegionState.State state) throws IOException { | |||
There was a problem hiding this comment.
This could be void addRegionStateToPut since return value is of no use as we are mutating Put?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…SED state again
This PR fix implementation of HBCKMetaTableAccessor.addRegionToMeta to insert new regions with CLOSED state, and also adds extra checks for this behaviour on both TestHBCKMetaTableAccessor and TestFsRegionsMetaRecoverer UTs.