HBASE-28102 [hbase-thirdparty] Bump hbase.stable.version to 2.4.17 in hbase-noop-h… #104

NihalJain · 2023-09-20T14:59:06Z

…trace

Also synced slf4j and junit version as per hbase 2.4.17 release
Added mockito-all as otherwise we get java.lang.NoClassDefFoundError: org/mockito/stubbing/Answer at org.apache.hadoop.hdfs.MiniDFSCluster.isNameNodeUp() for hbase versions built with hadoop >= 3.2.4

…trace

NihalJain · 2023-09-20T15:05:56Z

Hi @Apache9 I am not very sure around the semantics of when the hbase.stable.version should be bumped for hbase-noop-htrace module. I have raised this assuming the bumping was missed some how for some time now. Please feel free to close if this is not needed.

Apache-HBase · 2023-09-20T15:08:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 17s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
-1 ❌	mvninstall	0m 17s	root in master failed.
-1 ❌	compile	0m 17s	hbase-noop-htrace in master failed.
-1 ❌	javadoc	0m 17s	hbase-noop-htrace in master failed.
		_ Patch Compile Tests _
-1 ❌	mvninstall	0m 17s	hbase-noop-htrace in the patch failed.
-1 ❌	compile	0m 18s	hbase-noop-htrace in the patch failed.
-1 ❌	javac	0m 18s	hbase-noop-htrace in the patch failed.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
-1 ❌	javadoc	0m 17s	hbase-noop-htrace in the patch failed.
		_ Other Tests _
-1 ❌	unit	0m 17s	hbase-noop-htrace in the patch failed.
+0 🆗	asflicense	0m 17s	ASF License check generated no output?
		3m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#104
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux d21ce2c2ed27 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool	maven
git revision	master / `f82e745`
Default Java	Oracle Corporation-1.8.0_282-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/1/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/1/artifact/yetus-precommit-check/output/branch-compile-hbase-noop-htrace.txt
javadoc	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/1/artifact/yetus-precommit-check/output/branch-javadoc-hbase-noop-htrace.txt
mvninstall	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/1/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-noop-htrace.txt
compile	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/1/artifact/yetus-precommit-check/output/patch-compile-hbase-noop-htrace.txt
javac	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/1/artifact/yetus-precommit-check/output/patch-compile-hbase-noop-htrace.txt
javadoc	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/1/artifact/yetus-precommit-check/output/patch-javadoc-hbase-noop-htrace.txt
unit	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/1/artifact/yetus-precommit-check/output/patch-unit-hbase-noop-htrace.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/1/testReport/
Max. process+thread count	9 (vs. ulimit of 1000)
modules	C: hbase-noop-htrace U: hbase-noop-htrace
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/1/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-20T15:41:01Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	0m 50s	master passed
+1 💚	compile	0m 6s	master passed
+1 💚	javadoc	0m 8s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 9s	the patch passed
+1 💚	compile	0m 5s	the patch passed
+1 💚	javac	0m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 5s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 14s	hbase-noop-htrace in the patch failed.
+1 💚	asflicense	0m 6s	The patch does not generate ASF License warnings.
		2m 18s

Reason	Tests
Failed junit tests	hbase.htrace_noop.TestHBaseTestingUtilityWithHTraceNoop

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#104
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux fb130498d748 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool	maven
git revision	master / `f82e745`
Default Java	Oracle Corporation-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/2/artifact/yetus-precommit-check/output/patch-unit-hbase-noop-htrace.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/2/testReport/
Max. process+thread count	102 (vs. ulimit of 1000)
modules	C: hbase-noop-htrace U: hbase-noop-htrace
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/2/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

… org/mockito/stubbing/Answer at org.apache.hadoop.hdfs.MiniDFSCluster.isNameNodeUp() for hadoop >= 3.2.4

Apache-HBase · 2023-09-20T15:52:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	0m 51s	master passed
+1 💚	compile	0m 6s	master passed
+1 💚	javadoc	0m 7s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 9s	the patch passed
+1 💚	compile	0m 5s	the patch passed
+1 💚	javac	0m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 4s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 32s	hbase-noop-htrace in the patch passed.
+1 💚	asflicense	0m 6s	The patch does not generate ASF License warnings.
		2m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/3/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#104
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux 477ad19f6225 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool	maven
git revision	master / `f82e745`
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/3/testReport/
Max. process+thread count	383 (vs. ulimit of 1000)
modules	C: hbase-noop-htrace U: hbase-noop-htrace
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/3/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-20T16:08:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	0m 52s	master passed
+1 💚	compile	0m 6s	master passed
+1 💚	javadoc	0m 6s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 11s	the patch passed
+1 💚	compile	0m 5s	the patch passed
+1 💚	javac	0m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 33s	hbase-noop-htrace in the patch passed.
+1 💚	asflicense	0m 5s	The patch does not generate ASF License warnings.
		3m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/4/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#104
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux 2b1683fa9a2c 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 GNU/Linux
Build tool	maven
git revision	master / `f82e745`
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/4/testReport/
Max. process+thread count	384 (vs. ulimit of 1000)
modules	C: hbase-noop-htrace U: hbase-noop-htrace
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/4/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2023-09-20T23:45:18Z

Better to update it to the newest 2.4.x, as this version of thirdparty still needs to support hbase 2.4.x.

I think the next version will only need to support 2.5.x.

Thanks.

NihalJain · 2023-09-21T12:02:24Z

hbase-noop-htrace/pom.xml

    <!-- These maybe need to match the main repo -->
    <maven.checkstyle.version>3.1.0</maven.checkstyle.version>
    <checkstyle.version>8.29</checkstyle.version>
+    <!-- Added mockito-all as otherwise we get java.lang.NoClassDefFoundError:


Hi @Apache9 I have retained this change, although this should not be needed when compiling with hbase 2.4.x but would be use if compiling with 2.5.x. Let me know if you want to me to drop this.

Apache-HBase · 2023-09-21T12:06:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	0m 33s	master passed
+1 💚	compile	0m 6s	master passed
+1 💚	javadoc	0m 5s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 12s	the patch passed
+1 💚	compile	0m 5s	the patch passed
+1 💚	javac	0m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 26s	hbase-noop-htrace in the patch passed.
+1 💚	asflicense	0m 4s	The patch does not generate ASF License warnings.
		2m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/5/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#104
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux 891e430bc748 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 GNU/Linux
Build tool	maven
git revision	master / `f82e745`
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/5/testReport/
Max. process+thread count	386 (vs. ulimit of 1000)
modules	C: hbase-noop-htrace U: hbase-noop-htrace
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/5/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-21T14:29:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	0m 33s	master passed
+1 💚	compile	0m 6s	master passed
+1 💚	javadoc	0m 5s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 6s	the patch passed
+1 💚	compile	0m 5s	the patch passed
+1 💚	javac	0m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 4s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 27s	hbase-noop-htrace in the patch passed.
+1 💚	asflicense	0m 4s	The patch does not generate ASF License warnings.
		2m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/6/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#104
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux 3c4b14351f27 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 GNU/Linux
Build tool	maven
git revision	master / `f82e745`
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/6/testReport/
Max. process+thread count	405 (vs. ulimit of 1000)
modules	C: hbase-noop-htrace U: hbase-noop-htrace
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-104/6/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[hbase-thirdparty] Bump hbase.stable.version to 2.5.5 in hbase-noop-h…

394e8d0

…trace

NihalJain requested a review from Apache9 September 20, 2023 15:05

Added mockito-all as otherwise we get java.lang.NoClassDefFoundError:…

d8d4923

… org/mockito/stubbing/Answer at org.apache.hadoop.hdfs.MiniDFSCluster.isNameNodeUp() for hadoop >= 3.2.4

NihalJain force-pushed the HBASE-28102 branch from 6eeefbd to d8d4923 Compare September 20, 2023 15:49

NihalJain changed the title ~~[hbase-thirdparty] Bump hbase.stable.version to 2.5.5 in hbase-noop-h…~~ HBASE-28102 [hbase-thirdparty] Bump hbase.stable.version to 2.5.5 in hbase-noop-h… Sep 20, 2023

Change version to 2.4.17

f547fad

NihalJain changed the title ~~HBASE-28102 [hbase-thirdparty] Bump hbase.stable.version to 2.5.5 in hbase-noop-h…~~ HBASE-28102 [hbase-thirdparty] Bump hbase.stable.version to 2.4.17 in hbase-noop-h… Sep 21, 2023

NihalJain commented Sep 21, 2023

View reviewed changes

Apache9 approved these changes Sep 21, 2023

View reviewed changes

NihalJain merged commit 76026a8 into apache:master Sep 21, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28102 [hbase-thirdparty] Bump hbase.stable.version to 2.4.17 in hbase-noop-h… #104

HBASE-28102 [hbase-thirdparty] Bump hbase.stable.version to 2.4.17 in hbase-noop-h… #104

NihalJain commented Sep 20, 2023 •

edited

NihalJain commented Sep 20, 2023

Apache-HBase commented Sep 20, 2023

Apache-HBase commented Sep 20, 2023

Apache-HBase commented Sep 20, 2023

Apache-HBase commented Sep 20, 2023

Apache9 commented Sep 20, 2023

NihalJain Sep 21, 2023

Apache-HBase commented Sep 21, 2023

Apache-HBase commented Sep 21, 2023

HBASE-28102 [hbase-thirdparty] Bump hbase.stable.version to 2.4.17 in hbase-noop-h… #104

HBASE-28102 [hbase-thirdparty] Bump hbase.stable.version to 2.4.17 in hbase-noop-h… #104

Conversation

NihalJain commented Sep 20, 2023 • edited

NihalJain commented Sep 20, 2023

Apache-HBase commented Sep 20, 2023

Apache-HBase commented Sep 20, 2023

Apache-HBase commented Sep 20, 2023

Apache-HBase commented Sep 20, 2023

Apache9 commented Sep 20, 2023

NihalJain Sep 21, 2023

Choose a reason for hiding this comment

Apache-HBase commented Sep 21, 2023

Apache-HBase commented Sep 21, 2023

NihalJain commented Sep 20, 2023 •

edited