HBASE-23088 [hbase-thirdparty] Upgrade the dependencies for hbase-thi… #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busbey
requested changes
Sep 28, 2019
…rdparty netty-all: 4.1.34.Final => 4.1.41.Final guava: 27.1-jre => 28.1-jre commons-collections4: 4.3 => 4.4 protobuf: 3.7.1 => 3.9.2
Apache9
force-pushed
the
HBASE-23088
branch
from
b6cb4d9
to
86b77be
Compare
Done. |
busbey
requested changes
Sep 28, 2019
| @@ -141,7 +141,7 @@ | |||
| <dependency> | |||
| <groupId>io.netty</groupId> | |||
| <artifactId>netty-all</artifactId> | |||
| <version>4.1.34.Final</version> | |||
| <version>4.1.41.Final</version> | |||
There was a problem hiding this comment.
4.1.42 came out 3 days ago. Should use it?
There was a problem hiding this comment.
Let me address as an addendum. Tried pushing here but no perms.
saintstack
approved these changes
Sep 28, 2019
There was a problem hiding this comment.
Could update the netty as per @busbey comment before commit.
|
Merged because I want a commit in hbase-thirdparty-3.1.0 else build tooling fails. Will address Sean comment in an addendum. |
saintstack
added a commit
that referenced
this pull request
Sep 28, 2019
…rdparty (#7) Addendum upping netty from 4.1.41 to 4.1.42.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rdparty