-
Notifications
You must be signed in to change notification settings - Fork 217
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement Basic Constraint Based algorithm
- Loading branch information
Showing
11 changed files
with
398 additions
and
72 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
...ava/org/apache/helix/controller/rebalancer/waged/algorithm/RebalanceAlgorithmFactory.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| package org.apache.helix.controller.rebalancer.waged.algorithm; | ||
|
|
||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import org.apache.helix.HelixException; | ||
| import org.apache.helix.controller.rebalancer.waged.constraints.ConstraintBasedAlgorithm; | ||
| import org.apache.helix.controller.rebalancer.waged.constraints.HardConstraint; | ||
| import org.apache.helix.controller.rebalancer.waged.constraints.SoftConstraint; | ||
|
|
||
| public class RebalanceAlgorithmFactory { | ||
| private static Map<RebalanceAlgorithm.Type, RebalanceAlgorithm> INSTANCES = new HashMap<>(); | ||
|
|
||
| public static synchronized RebalanceAlgorithm getInstance(RebalanceAlgorithm.Type type) { | ||
| if (INSTANCES.containsKey(type)) { | ||
| return INSTANCES.get(type); | ||
| } | ||
|
|
||
| switch (type) { | ||
| case CONSTRAINTS: | ||
| // TODO initialize constraints, depending on constraints PRs | ||
| List<HardConstraint> hardConstraints = new ArrayList<>(); | ||
| List<SoftConstraint> softConstraints = new ArrayList<>(); | ||
| RebalanceAlgorithm constraintBaseAlgorithm = new ConstraintBasedAlgorithm(hardConstraints, softConstraints); | ||
| INSTANCES.put(RebalanceAlgorithm.Type.CONSTRAINTS, constraintBaseAlgorithm); | ||
| return constraintBaseAlgorithm; | ||
| default: | ||
| throw new HelixException("Unsupported algorithm type: " + type); | ||
| } | ||
| } | ||
| } |
116 changes: 116 additions & 0 deletions
116
...va/org/apache/helix/controller/rebalancer/waged/constraints/ConstraintBasedAlgorithm.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| package org.apache.helix.controller.rebalancer.waged.constraints; | ||
|
|
||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Comparator; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Optional; | ||
| import java.util.Set; | ||
| import java.util.function.Function; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| import org.apache.helix.controller.rebalancer.waged.algorithm.RebalanceAlgorithm; | ||
| import org.apache.helix.controller.rebalancer.waged.model.AssignableNode; | ||
| import org.apache.helix.controller.rebalancer.waged.model.AssignableReplica; | ||
| import org.apache.helix.controller.rebalancer.waged.model.ClusterContext; | ||
| import org.apache.helix.controller.rebalancer.waged.model.ClusterModel; | ||
| import org.apache.helix.controller.rebalancer.waged.model.OptimalAssignment; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
|
|
||
|
|
||
| /** | ||
| * The algorithm is based on a given set of constraints | ||
| * - HardConstraint: Approve or deny the assignment given its condition, any assignment cannot | ||
| * bypass any "hard constraint" | ||
| * - SoftConstraint: Evaluate the assignment by points/rewards/scores, a higher point means a better | ||
| * assignment | ||
| * The goal is to accumulate the most points(rewards) from "soft constraints" while avoiding any | ||
| * "hard constraints" | ||
| */ | ||
| public class ConstraintBasedAlgorithm implements RebalanceAlgorithm { | ||
| private static final Logger LOG = LoggerFactory.getLogger(ConstraintBasedAlgorithm.class); | ||
| private final List<HardConstraint> _hardConstraints; | ||
| private final List<SoftConstraint> _softConstraints; | ||
|
|
||
| public ConstraintBasedAlgorithm(List<HardConstraint> hardConstraints, | ||
| List<SoftConstraint> softConstraints) { | ||
| _hardConstraints = hardConstraints; | ||
| _softConstraints = softConstraints; | ||
| } | ||
|
|
||
| @Override | ||
| public OptimalAssignment calculate(ClusterModel clusterModel) { | ||
| OptimalAssignment optimalAssignment = new OptimalAssignment(); | ||
| Map<String, Set<AssignableReplica>> replicasByResource = clusterModel.getAssignableReplicaMap(); | ||
| List<AssignableNode> nodes = new ArrayList<>(clusterModel.getAssignableNodes().values()); | ||
|
|
||
| // TODO: different orders of resource/replica could lead to different greedy assignments, will | ||
| // revisit and improve the performance | ||
| for (String resource : replicasByResource.keySet()) { | ||
| for (AssignableReplica replica : replicasByResource.get(resource)) { | ||
| Optional<AssignableNode> maybeBestNode = | ||
| getNodeWithHighestPoints(replica, nodes, clusterModel.getContext(), optimalAssignment); | ||
| // stop immediately if any replica cannot find best assignable node | ||
| if (optimalAssignment.hasAnyFailure()) { | ||
| LOG.error("Unable to find any available candidate node for partition {}; Fail reasons: {}", | ||
| replica.getPartitionName(), optimalAssignment.getFailures()); | ||
| return optimalAssignment; | ||
| } | ||
| maybeBestNode.ifPresent(node -> clusterModel.assign(replica.getResourceName(), replica.getPartitionName(), | ||
| replica.getReplicaState(), node.getInstanceName())); | ||
| } | ||
| } | ||
|
|
||
| return optimalAssignment.convertFrom(clusterModel); | ||
| } | ||
|
|
||
| private Optional<AssignableNode> getNodeWithHighestPoints(AssignableReplica replica, | ||
| List<AssignableNode> assignableNodes, ClusterContext clusterContext, OptimalAssignment optimalAssignment) { | ||
| Map<AssignableNode, List<HardConstraint>> hardConstraintFailures = new HashMap<>(); | ||
| List<AssignableNode> candidateNodes = assignableNodes.stream().filter(candidateNode -> { | ||
| boolean isValid = true; | ||
| // need to record all the failure reasons and it gives us the ability to debug/fix the runtime | ||
| // cluster environment | ||
| for (HardConstraint hardConstraint : _hardConstraints) { | ||
| if (!hardConstraint.isAssignmentValid(candidateNode, replica, clusterContext)) { | ||
| hardConstraintFailures.computeIfAbsent(candidateNode, node -> new ArrayList<>()).add(hardConstraint); | ||
| isValid = false; | ||
| } | ||
| } | ||
| return isValid; | ||
| }).collect(Collectors.toList()); | ||
| if (candidateNodes.isEmpty()) { | ||
| optimalAssignment.recordAssignmentFailure(replica, hardConstraintFailures); | ||
| return Optional.empty(); | ||
| } | ||
|
|
||
| Function<AssignableNode, Double> calculatePoints = | ||
| (candidateNode) -> _softConstraints.stream().map(softConstraint -> softConstraint | ||
| .getAssignmentOriginScore(candidateNode, replica, clusterContext)) | ||
| .mapToDouble(score -> score).sum(); | ||
|
|
||
| return candidateNodes.stream().max(Comparator.comparing(calculatePoints)); | ||
| } | ||
| } |
48 changes: 0 additions & 48 deletions
48
...g/apache/helix/controller/rebalancer/waged/constraints/ConstraintsRebalanceAlgorithm.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.