New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up after TestAuthValidator -- fix TestClusterAccessor #2097
Conversation
private static String CLASSNAME_TEST_CST_AUTH = "testCustomAuthValidator"; | ||
|
||
@AfterClass | ||
public void afterClass() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for my ignorance, but shouldn't we be deleting Helix Cluster, rather than directly using zkclient to delete znodes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments...I updated.
helix-rest/src/test/java/org/apache/helix/rest/server/TestAuthValidator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@xyuanlu final commit message? |
Thanks for review. Final commit message: Clean up after TestAuthValidator -- fix TestClusterAccessor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making all the required changes. LGTM
Issues
#2096
#2093
Description
TestAuthValidator create 2 clusters testDefaultAuthValidator and testCustomAuthValidator. These 2 clusters are not cleaned up causing TestClusterAccessor. testGetClusters to fail.
Tests
NA
CU result:
testHelixViewAggregator(org.apache.helix.view.integration.TestHelixViewAggregator)
Link to issue: [Failed CI Test] testHelixViewAggregator(org.apache.helix.view.integration.TestHelixViewAggregator) #2049
local run:
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)