Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up after TestAuthValidator -- fix TestClusterAccessor #2097

Merged
merged 3 commits into from May 31, 2022

Conversation

xyuanlu
Copy link
Contributor

@xyuanlu xyuanlu commented May 16, 2022

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2096
#2093

Description

  • Here are some details about my PR, including screenshots of any UI changes:

TestAuthValidator create 2 clusters testDefaultAuthValidator and testCustomAuthValidator. These 2 clusters are not cleaned up causing TestClusterAccessor. testGetClusters to fail.

Tests

  • The following tests are written for this issue:

NA

[INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 183.686 s - in TestSuite
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- jacoco-maven-plugin:0.8.6:report (generate-code-coverage-report) @ helix-view-aggregator ---
[INFO] Loading execution data file /Users/xialu/Documents/WorkSpace/helix/helix-view-aggregator/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: View Aggregator' with 15 classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:09 min
[INFO] Finished at: 2022-05-27T22:28:57-07:00
[INFO] ------------------------------------------------------------------------

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

private static String CLASSNAME_TEST_CST_AUTH = "testCustomAuthValidator";

@AfterClass
public void afterClass() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for my ignorance, but shouldn't we be deleting Helix Cluster, rather than directly using zkclient to delete znodes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments...I updated.

Copy link
Contributor

@desaikomal desaikomal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@junkaixue
Copy link
Contributor

@xyuanlu final commit message?

@xyuanlu
Copy link
Contributor Author

xyuanlu commented May 18, 2022

Thanks for review.

Final commit message:

Clean up after TestAuthValidator -- fix TestClusterAccessor

Copy link
Contributor

@desaikomal desaikomal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making all the required changes. LGTM

@NealSun96 NealSun96 merged commit 1a1fe31 into apache:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants