Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tslib, set import-helpers: false [helix-front] #2166

Merged
merged 2 commits into from Aug 4, 2022

Conversation

micahstubbs
Copy link
Contributor

@micahstubbs micahstubbs commented Jun 24, 2022

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2165

Description

  • Here are some details about my PR, including screenshots of any UI changes:

https://www.npmjs.com/package/tslib

https://stackoverflow.com/questions/51732554/cannot-find-module-tslib?answertab=trending#tab-top

angular/angular-cli#13886

https://www.typescriptlang.org/tsconfig#importHelpers

Tests

  • The following tests are written for this issue:

Tooling change only, no new tests.

Commits

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@micahstubbs micahstubbs changed the title yarn add tslib [helix-front] update tslib, set import-helpers: false [helix-front] Aug 4, 2022
@micahstubbs
Copy link
Contributor Author

micahstubbs commented Aug 4, 2022

CI failure appears to be an unrelated ZK issue:

45828 [ZkClient-AsyncCallback-Retry-206-localhost:2127] ERROR 
org.apache.helix.zookeeper.zkclient.callback.ZkAsyncRetryThread [] - Error retrying callback 
org.apache.helix.zookeeper.impl.client.TestZkClientAsyncRetry$MockAsyncZkClient$1@4278a9b7, 
cancelling it
org.apache.helix.zookeeper.zkclient.exception.ZkException: null

https://github.com/apache/helix/runs/7662436946?check_suite_focus=true

@micahstubbs
Copy link
Contributor Author

This PR is ready to be merged, approved by @NealSun96

Final commit message:

update tslib, set import-helpers: false [helix-front] (#2166)

Ensure that consumers of helix-front do not themselves need tslib as a direct dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants