[HELIX-751] TASK: Fix AssignableInstanceComparator so that it sorts unsupported quota types #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narendly
changed the title
junkaixue
approved these changes
Sep 19, 2018
…nsupported quota types Currently, if the quota type does not exist, it will not sort AssignableInstances based on availability. This does not cause immediate problems, but it would be nice to have them sorted because we now allow unsupported quota types run as DEFAULT type. Changelist: 1. Comparator sorts AssignableInstances in a PriorityQueue by DEFAULT type's availability when the quota type given is unsupported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nsupported quota types
Currently, if the quota type does not exist, it will not sort AssignableInstances based on availability. This does not cause immediate problems, but it would be nice to have them sorted because we now allow unsupported quota types run as DEFAULT type.
Changelist: