Fix long version of quickstart guide of helix 0.8.4 release. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgreenbar
commented
May 7, 2019
alexgreenbar
commented
- fix the wrong command parameter
- add the command output
1. fix the wrong command parameter 2. add the command output
jiajunwang
reviewed
May 7, 2019
| @@ -406,7 +406,55 @@ Now, let\'s look at one of the partitions: | |||
|
|
|||
| ``` | |||
| # helix-admin.sh --zkSvr <zk_address> --listResourceInfo <clusterName> <partition> | |||
There was a problem hiding this comment.
Good catch! Could you please also update the template here? Should be listPartitionInfo as well.
There was a problem hiding this comment.
Good catch! Could you please also update the template here? Should be listPartitionInfo as well.
Fix the command template and corresponding example.
3. Fix the command template and example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.