Dynamically change the processor thread name when consuming event

[i3wangyi]

Description
Here are some details about my PR, including screenshots of any UI changes:
(Write a concise description including what, why, how)

What
Change the thread name at run time for processing every event.

Why?
It tries to solve the pain point when developers need to grep the entire log history of a single event based on its event id. We do add the event id in some of our pipeline stages, but it's not convenient and incomplete.

Modifying the running thread at run time whenever an event is consumed is much more convenient.

Example:

Event id:  5f1e26a8_DEFAULT
Enqueue : 5f1e26a8_TASK
Enqueue : 3ddd0a91_DEFAULT
Enqueue : 3ddd0a91_TASK
Current thread name: HelixController-pipeline-default-TestCluster(5f1e26a8_DEFAULT)

Tests
N/A
Manually tested, verified in the above example. It doesn't change any functionality of Helix.

Code Quality
My diff has been formatted using helix-style.xml

[narendly]

Could we format the PR per the guidelines? :)

…

On Jul 24, 2019, 07:17, at 07:17, jiajunwang ***@***.***> wrote: jiajunwang commented on this pull request. > @@ -1165,7 +1164,11 @@ public void run() { + _processorName); while (!isInterrupted()) { try { - handleEvent(_eventBlockingQueue.take(), _cache); + ClusterEvent newClusterEvent = _eventBlockingQueue.take(); + // rename the current processor's thread name to include event id + String currentThreadName = this.getName().split("_")[0]; The thread name shall be fixed, You can just regenerate the name according to our name convention. > @@ -1165,7 +1164,11 @@ public void run() { + _processorName); while (!isInterrupted()) { try { - handleEvent(_eventBlockingQueue.take(), _cache); + ClusterEvent newClusterEvent = _eventBlockingQueue.take(); + // rename the current processor's thread name to include event id + String currentThreadName = this.getName().split("_")[0]; + this.setName(currentThreadName + "_" + newClusterEvent.getEventId()); Can we use "()" to wrap the event? I feel it's easier to identify which part is the default thread name, and which part is the event name. > @@ -1165,7 +1164,11 @@ public void run() { + _processorName); while (!isInterrupted()) { try { - handleEvent(_eventBlockingQueue.take(), _cache); + ClusterEvent newClusterEvent = _eventBlockingQueue.take(); + // rename the current processor's thread name to include event id + String currentThreadName = this.getName().split("_")[0]; + this.setName(currentThreadName + "_" + newClusterEvent.getEventId()); + handleEvent(newClusterEvent, _cache); Would it be better to set the event id inside handleEvent()? Logic will be more concise. And remember that we'd better recover the thread name after the handling logic. Probably in some final block. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #359 (review)

[lei-xia]

Please verify this in your local deployment to make sure it works as expected

[i3wangyi]

Please verify this in your local deployment to make sure it works as expected

It's working as expected while running controller locally. What I did is to print the thread name, it's something like HelixController-pipeline-default-TestCluster(5f1e26a8_DEFAULT)

[i3wangyi]

This PR is ready to be merged, approved by @lei-xia