Add import order for java and javax. #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiajunwang
reviewed
Sep 30, 2019
jiajunwang
approved these changes
Oct 10, 2019
narendly
pushed a commit
to narendly/helix
that referenced
this pull request
Dec 24, 2019
* Add import order for java and javax. * Remve the empty line between java and javax.
mgao0
pushed a commit
to mgao0/helix
that referenced
this pull request
Mar 6, 2020
* Add import order for java and javax. * Remve the empty line between java and javax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Add import order for java and javax. #499 Add import order for java and javax.
Description
(Write a concise description including what, why, how)
Set import order for java and javax in helix code style xml.
Order will be java, javax.
Tests
The following tests are written for this issue:
(List the names of added unit/integration tests)
The following is the result of the "mvn test" command on the appropriate module:
(Copy & paste the result of "mvn test")
Commits
My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"
Documentation
In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
Code Quality