Fix null response for instance stoppable check when connection refused. #504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Null returned for instance stoppable check when connection refused #503 Null returned for instance stoppable check when connection refused
Description
(Write a concise description including what, why, how)
instance stoppable check endpoint
/clusters/<cluster>/instances/<instanceId>/stoppable
return null when connection between helix rest server and storage node.We return a
StoppableCheck
object when connection refused.Tests
The following tests are written for this issue:
(List the names of added unit/integration tests)
testGetInstanceStoppableCheckConnectionRefused
The following is the result of the "mvn test" command on the appropriate module:
(Copy & paste the result of "mvn test")
[INFO] Tests run: 86, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.438 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 86, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30.896 s
[INFO] Finished at: 2019-10-03T19:13:15-07:00
[INFO] ------------------------------------------------------------------------
Commits
My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"
Documentation
In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
Code Quality