Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null response for instance stoppable check when connection refused. #504

Merged
merged 3 commits into from Oct 23, 2019

Conversation

huizhilu
Copy link
Contributor

@huizhilu huizhilu commented Oct 4, 2019

Issues

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    (Write a concise description including what, why, how)
    instance stoppable check endpoint /clusters/<cluster>/instances/<instanceId>/stoppable return null when connection between helix rest server and storage node.
    We return a StoppableCheck object when connection refused.

Tests

  • The following tests are written for this issue:
    (List the names of added unit/integration tests)
    testGetInstanceStoppableCheckConnectionRefused

  • The following is the result of the "mvn test" command on the appropriate module:
    (Copy & paste the result of "mvn test")

[INFO] Tests run: 86, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.438 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 86, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30.896 s
[INFO] Finished at: 2019-10-03T19:13:15-07:00
[INFO] ------------------------------------------------------------------------

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    Subject is separated from body by a blank line
    Subject is limited to 50 characters (not including Jira issue reference)
    Subject does not end with a period
    Subject uses the imperative mood ("add", not "adding")
    Body wraps at 72 characters
    Body explains "what" and "why", not "how"
    Documentation

    In case of new functionality, my PR adds documentation in the following wiki page:
    (Link the GitHub wiki you added)

Code Quality

  • My diff has been formatted using helix-style-intellij.xml

@huizhilu huizhilu changed the title Fix null value for instance stoppable check when connection refused. Fix null response for instance stoppable check when connection refused. Oct 4, 2019
@huizhilu
Copy link
Contributor Author

huizhilu commented Oct 14, 2019

This PR is ready to be merged, approved by @dasahcc

Final commit message:
Issue: Instance stoppable check endpoint /clusters//instances//stoppable returns null when connection between helix rest server and storage node.
This diff fixes this by: return a StoppableCheck object when connection refused.

@narendly narendly merged commit 824bc95 into apache:master Oct 23, 2019
narendly pushed a commit to narendly/helix that referenced this pull request Dec 24, 2019
…d. (apache#504)

Issue: Instance stoppable check endpoint /clusters//instances//stoppable returns null when connection between helix rest server and storage node.
This diff fixes this by: return a StoppableCheck object when connection refused.
mgao0 pushed a commit to mgao0/helix that referenced this pull request Mar 6, 2020
…d. (apache#504)

Issue: Instance stoppable check endpoint /clusters//instances//stoppable returns null when connection between helix rest server and storage node.
This diff fixes this by: return a StoppableCheck object when connection refused.
@huizhilu huizhilu deleted the stoppableCheck branch July 20, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants