-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add write REST endpoints to helix rest for metadata store directory #757
Conversation
...ava/org/apache/helix/rest/server/resources/metadatastore/MetadataStoreDirectoryAccessor.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/helix/rest/server/resources/metadatastore/MetadataStoreDirectoryAccessor.java
Show resolved
Hide resolved
@narendly I pushed a new commit to fix unit tests, update tests to use namespaced APIs and remove deprecated classes. Tests all pass. Can you take a look again? Thanks. |
...rest/src/test/java/org/apache/helix/rest/metadatastore/accessor/TestZkRoutingDataReader.java
Outdated
Show resolved
Hide resolved
...rest/src/test/java/org/apache/helix/rest/metadatastore/accessor/TestZkRoutingDataReader.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/helix/rest/server/resources/zookeeper/TestMetadataStoreDirectoryAccessor.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/helix/rest/server/resources/zookeeper/TestMetadataStoreDirectoryAccessor.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/helix/rest/server/resources/zookeeper/TestMetadataStoreDirectoryAccessor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments :) Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is ready to be merged, approved by @narendly
Commit message:
We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST.
Changelist:
- Add REST write endpoints to MetadataStoreDirectoryAccessor
- Add unit tests for the new REST write endpoints
- Fix unit tests by cleaning up routing data path in ZK
...ava/org/apache/helix/rest/server/resources/zookeeper/TestMetadataStoreDirectoryAccessor.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/helix/rest/server/resources/zookeeper/TestMetadataStoreDirectoryAccessor.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/helix/rest/server/resources/zookeeper/TestMetadataStoreDirectoryAccessor.java
Show resolved
Hide resolved
...rest/src/test/java/org/apache/helix/rest/metadatastore/accessor/TestZkRoutingDataReader.java
Show resolved
Hide resolved
…pache#757) We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST. Changelist: - Add REST write endpoints to MetadataStoreDirectoryAccessor - Add unit tests for the new REST write endpoints - Fix unit tests by cleaning up routing data path in ZK
…pache#757) We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST. Changelist: - Add REST write endpoints to MetadataStoreDirectoryAccessor - Add unit tests for the new REST write endpoints - Fix unit tests by cleaning up routing data path in ZK
…pache#757) We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST. Changelist: - Add REST write endpoints to MetadataStoreDirectoryAccessor - Add unit tests for the new REST write endpoints - Fix unit tests by cleaning up routing data path in ZK
…pache#757) We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST. Changelist: - Add REST write endpoints to MetadataStoreDirectoryAccessor - Add unit tests for the new REST write endpoints - Fix unit tests by cleaning up routing data path in ZK
…757) We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST. Changelist: - Add REST write endpoints to MetadataStoreDirectoryAccessor - Add unit tests for the new REST write endpoints - Fix unit tests by cleaning up routing data path in ZK
…757) We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST. Changelist: - Add REST write endpoints to MetadataStoreDirectoryAccessor - Add unit tests for the new REST write endpoints - Fix unit tests by cleaning up routing data path in ZK
…757) We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST. Changelist: - Add REST write endpoints to MetadataStoreDirectoryAccessor - Add unit tests for the new REST write endpoints - Fix unit tests by cleaning up routing data path in ZK
…pache#757) We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST. Changelist: - Add REST write endpoints to MetadataStoreDirectoryAccessor - Add unit tests for the new REST write endpoints - Fix unit tests by cleaning up routing data path in ZK
Issues
Implements #756
Description
We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access.
This PR the adds MSDS write endpoints to Helix REST.
Tests
The following tests are written for this issue:
testAddMetadataStoreRealm
testDeleteMetadataStoreRealm
testAddShardingKey
testDeleteShardingKey
The following is the result of the "mvn test" command on the appropriate module:
Tests depend on the write operations in ZkMeatadataStoreDirectory. Needs to enable asserts before tests are really testing the operations successfully.
Commits
Documentation
(Link the GitHub wiki you added)
Code Quality