Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write REST endpoints to helix rest for metadata store directory #757

Merged
merged 6 commits into from
Feb 13, 2020

Conversation

huizhilu
Copy link
Contributor

@huizhilu huizhilu commented Feb 12, 2020

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Implements #756

Description

  • Here are some details about my PR, including screenshots of any UI changes:

We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access.
This PR the adds MSDS write endpoints to Helix REST.

Tests

  • The following tests are written for this issue:

  • testAddMetadataStoreRealm

  • testDeleteMetadataStoreRealm

  • testAddShardingKey

  • testDeleteShardingKey

  • The following is the result of the "mvn test" command on the appropriate module:

Tests depend on the write operations in ZkMeatadataStoreDirectory. Needs to enable asserts before tests are really testing the operations successfully.

[INFO] Tests run: 140, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.924 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 140, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  32.646 s
[INFO] Finished at: 2020-02-12T20:44:10-08:00
[INFO] ------------------------------------------------------------------------

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Code Quality

  • My diff has been formatted using helix-style.xml

@huizhilu
Copy link
Contributor Author

@narendly I pushed a new commit to fix unit tests, update tests to use namespaced APIs and remove deprecated classes. Tests all pass. Can you take a look again? Thanks.

Copy link
Contributor

@narendly narendly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments :) Great work!

Copy link
Contributor Author

@huizhilu huizhilu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is ready to be merged, approved by @narendly

Commit message:

We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST.

Changelist:
- Add REST write endpoints to MetadataStoreDirectoryAccessor
- Add unit tests for the new REST write endpoints 
- Fix unit tests by cleaning up routing data path in ZK

@narendly narendly merged commit 15e5ec7 into apache:zooscalability Feb 13, 2020
narendly pushed a commit to narendly/helix that referenced this pull request Mar 10, 2020
…pache#757)

We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST.

Changelist:
- Add REST write endpoints to MetadataStoreDirectoryAccessor
- Add unit tests for the new REST write endpoints 
- Fix unit tests by cleaning up routing data path in ZK
narendly pushed a commit to narendly/helix that referenced this pull request Mar 17, 2020
…pache#757)

We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST.

Changelist:
- Add REST write endpoints to MetadataStoreDirectoryAccessor
- Add unit tests for the new REST write endpoints 
- Fix unit tests by cleaning up routing data path in ZK
narendly pushed a commit to narendly/helix that referenced this pull request Apr 1, 2020
…pache#757)

We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST.

Changelist:
- Add REST write endpoints to MetadataStoreDirectoryAccessor
- Add unit tests for the new REST write endpoints 
- Fix unit tests by cleaning up routing data path in ZK
narendly pushed a commit to narendly/helix that referenced this pull request Apr 1, 2020
…pache#757)

We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST.

Changelist:
- Add REST write endpoints to MetadataStoreDirectoryAccessor
- Add unit tests for the new REST write endpoints 
- Fix unit tests by cleaning up routing data path in ZK
asfgit pushed a commit that referenced this pull request Apr 1, 2020
…757)

We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST.

Changelist:
- Add REST write endpoints to MetadataStoreDirectoryAccessor
- Add unit tests for the new REST write endpoints 
- Fix unit tests by cleaning up routing data path in ZK
asfgit pushed a commit that referenced this pull request Apr 8, 2020
…757)

We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST.

Changelist:
- Add REST write endpoints to MetadataStoreDirectoryAccessor
- Add unit tests for the new REST write endpoints 
- Fix unit tests by cleaning up routing data path in ZK
narendly pushed a commit that referenced this pull request Apr 9, 2020
…757)

We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST.

Changelist:
- Add REST write endpoints to MetadataStoreDirectoryAccessor
- Add unit tests for the new REST write endpoints 
- Fix unit tests by cleaning up routing data path in ZK
@huizhilu huizhilu deleted the write-rest branch July 20, 2020 06:31
huizhilu added a commit to huizhilu/helix that referenced this pull request Aug 16, 2020
…pache#757)

We have metadata store directory service to help scale out zookeeper. Metadata store directory service provides REST APIs to access. This commit adds MSDS write endpoints to Helix REST.

Changelist:
- Add REST write endpoints to MetadataStoreDirectoryAccessor
- Add unit tests for the new REST write endpoints 
- Fix unit tests by cleaning up routing data path in ZK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants