New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ClusterSetup realm-aware #861
Conversation
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But please address remaining concerns.
This PR is ready to be merged, approved by @dasahcc We make ClusterSetup, a Helix Java API, realm-aware so that this could be used in a multi-ZK environment. Add a Builder to enable users to set internal ZkClient parameters |
We make ClusterSetup, a Helix Java API, realm-aware so that this could be used in a multi-ZK environment. Changelist: Add a Builder to enable users to set internal ZkClient parameters Add the realm-aware behavior in existing constructors Update ConfigAccessor to reflect the change in the logic
We make ClusterSetup, a Helix Java API, realm-aware so that this could be used in a multi-ZK environment. Changelist: Add a Builder to enable users to set internal ZkClient parameters Add the realm-aware behavior in existing constructors Update ConfigAccessor to reflect the change in the logic
We make ClusterSetup, a Helix Java API, realm-aware so that this could be used in a multi-ZK environment. Changelist: Add a Builder to enable users to set internal ZkClient parameters Add the realm-aware behavior in existing constructors Update ConfigAccessor to reflect the change in the logic
We make ClusterSetup, a Helix Java API, realm-aware so that this could be used in a multi-ZK environment. Changelist: Add a Builder to enable users to set internal ZkClient parameters Add the realm-aware behavior in existing constructors Update ConfigAccessor to reflect the change in the logic
We make ClusterSetup, a Helix Java API, realm-aware so that this could be used in a multi-ZK environment. Changelist: Add a Builder to enable users to set internal ZkClient parameters Add the realm-aware behavior in existing constructors Update ConfigAccessor to reflect the change in the logic
We make ClusterSetup, a Helix Java API, realm-aware so that this could be used in a multi-ZK environment. Changelist: Add a Builder to enable users to set internal ZkClient parameters Add the realm-aware behavior in existing constructors Update ConfigAccessor to reflect the change in the logic
We make ClusterSetup, a Helix Java API, realm-aware so that this could be used in a multi-ZK environment. Changelist: Add a Builder to enable users to set internal ZkClient parameters Add the realm-aware behavior in existing constructors Update ConfigAccessor to reflect the change in the logic
Issues
#860
Description
We make ClusterSetup, a Helix Java API, realm-aware so that this could be used in a multi-ZK environment.
Changelist:
Tests
TestClusterSetup covers this.
helix-core:
All tests pass when run individually.
Commits
Documentation (Optional)
(Link the GitHub wiki you added)
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)