Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor verify http collect response status code #1014

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented Jun 6, 2023

What's changed?

refactor verify http collect response status code
support api monitoring can custom update success status code in web ui

image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Jun 6, 2023
@tomsun28 tomsun28 requested a review from l646505418 June 6, 2023 05:56
@tomsun28
Copy link
Contributor Author

tomsun28 commented Jun 6, 2023

should update h2 database with sql:

ALTER TABLE HZB_PARAM  DROP CONSTRAINT CONSTRAINT_82; 

@l646505418
Copy link
Contributor

should update h2 database with sql:

ALTER TABLE HZB_PARAM  DROP CONSTRAINT CONSTRAINT_82; 

if the statusCodes is list of String ,I think maybe can support fuzzy query,for example ,5** can match 501,502,503 codeetc

@tomsun28
Copy link
Contributor Author

tomsun28 commented Jun 6, 2023

@l646505418 good idea! Make the successCodes is string, because of yml parse the successCodes: [^_^successCode^_^] error when successCodes is array number.

@tomsun28
Copy link
Contributor Author

tomsun28 commented Jun 6, 2023

4xx , 5xx, 3xx, 2xx may better

@l646505418
Copy link
Contributor

4xx , 5xx, 3xx, 2xx may better

mayeb hertzbeat is widely used by developers and devops, so they should be very familiar with shell and regex
So maybe 2**will be better?

@tomsun28
Copy link
Contributor Author

tomsun28 commented Jun 6, 2023

4xx , 5xx, 3xx, 2xx may better

mayeb hertzbeat is widely used by developers and devops, so they should be very familiar with shell and regex So maybe 2**will be better?

ok, we can support all. haha

@l646505418 l646505418 merged commit 38e9032 into master Jun 7, 2023
2 checks passed
@tomsun28 tomsun28 deleted the refactor-status-code branch June 7, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants