Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix can not startup when error monitoring template yml file #1153

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented Aug 4, 2023

What's changed?

bugfix can not startup when error monitoring template yml file
Ignore parse error monitoring template yml file

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@@ -328,14 +329,18 @@ public void run(String... args) throws Exception {
log.info("load define path {}", defineAppPath);
for (File appFile : Objects.requireNonNull(directory.listFiles())) {
if (appFile.exists() && appFile.isFile()) {
if (appFile.isHidden()
|| (!appFile.getName().endsWith("yml") && !appFile.getName().endsWith("yaml"))) {
log.error("Ignore this template file: {}.", appFile.getName());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不用continue吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的 我修改下

@tomsun28 tomsun28 merged commit d46b922 into master Aug 7, 2023
2 checks passed
@tomsun28 tomsun28 deleted the ignore-error-yml branch August 7, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix enhancement New feature or request
Projects
None yet
2 participants