bugfix app-tomcat memory_pool unit mb #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my first submission, so I don’t quite understand it. |
1 task
tomsun28
changed the title
|
@all-contributors please add @rbsrcy for code |
|
I've put up a pull request to add @rbsrcy! 🎉 |
tomsun28
reviewed
Oct 8, 2023
Comment on lines
187
to
194
| # (optional)metrics field alias name, it is used as an alias field to map and convert the collected data and metrics field | ||
| # (可选)监控指标别名, 做为中间字段与采集数据字段和指标字段映射转换 | ||
| aliasFields: | ||
| - Name | ||
| - Usage->committed | ||
| - Usage->init | ||
| - Usage->max | ||
| - Usage->used |
There was a problem hiding this comment.
hi 这里不能把 aliasFields参数去掉 这是从 Usage 拿子参数
tomsun28
pushed a commit
that referenced
this pull request
Jan 16, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
change app-tomcat memory_pool use MB as unit.
change app-tomcat memory_pool use MB as unit.
Checklist