Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert tests fix #1501

Merged
merged 12 commits into from
Jan 20, 2024
Merged

Alert tests fix #1501

merged 12 commits into from
Jan 20, 2024

Conversation

a-little-fool
Copy link
Contributor

What's changed?

fix AlertDefineServiceTest error

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@a-little-fool a-little-fool self-assigned this Jan 20, 2024
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers bugfix labels Jan 20, 2024
@tomsun28 tomsun28 added this to the 1.4.5 milestone Jan 20, 2024
tomsun28
tomsun28 approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@tomsun28 tomsun28 merged commit 1c1b955 into master Jan 20, 2024
2 checks passed
@a-little-fool a-little-fool deleted the alert-tests-fix branch January 20, 2024 06:26
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@a-little-fool @yqxxgh @tomsun28
Alert tests fix (#1501)
57f2e9b 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: yqxxgh <1135131038@qq.com>
Co-authored-by: yqxxgh <42080876+yqxxgh@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@a-little-fool @yqxxgh @tomsun28
Alert tests fix (#1501)
79822a8 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: yqxxgh <1135131038@qq.com>
Co-authored-by: yqxxgh <42080876+yqxxgh@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@a-little-fool @yqxxgh @tomsun28
Alert tests fix (#1501)
896c9f7 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: yqxxgh <1135131038@qq.com>
Co-authored-by: yqxxgh <42080876+yqxxgh@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
@a-little-fool @yqxxgh @tomsun28
Alert tests fix (#1501)
838554b 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: yqxxgh <1135131038@qq.com>
Co-authored-by: yqxxgh <42080876+yqxxgh@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
@a-little-fool @yqxxgh @tomsun28
Alert tests fix (#1501)
94286dc 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: yqxxgh <1135131038@qq.com>
Co-authored-by: yqxxgh <42080876+yqxxgh@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@a-little-fool @yqxxgh @tomsun28
Alert tests fix (#1501)
d3c1929 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: yqxxgh <1135131038@qq.com>
Co-authored-by: yqxxgh <42080876+yqxxgh@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@a-little-fool @yqxxgh @tomsun28
Alert tests fix (#1501)
b86e197 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: yqxxgh <1135131038@qq.com>
Co-authored-by: yqxxgh <42080876+yqxxgh@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@a-little-fool @yqxxgh @tomsun28
Alert tests fix (#1501)
f08ea1f 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: yqxxgh <1135131038@qq.com>
Co-authored-by: yqxxgh <42080876+yqxxgh@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@a-little-fool @yqxxgh @tomsun28
Alert tests fix (#1501)
7ae9f5f 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: yqxxgh <1135131038@qq.com>
Co-authored-by: yqxxgh <42080876+yqxxgh@users.noreply.github.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees

@a-little-fool a-little-fool

Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a-little-fool @tomsun28 @yqxxgh