Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert yml config #1535

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Alert yml config #1535

merged 5 commits into from
Feb 5, 2024

Conversation

zqr10159
Copy link
Member

@zqr10159 zqr10159 commented Feb 4, 2024

What's changed?

Alert yml config

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Feb 4, 2024
@tomsun28
Copy link
Contributor

tomsun28 commented Feb 5, 2024

👍,hi建议不把不同环境分离出来做成独立yml,因为docker挂载的时候就需要再挂载一个,但是我们对外文档说明一直都是挂载那个 application.yml,改了之后会造成疑虑

@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


👍, Hi, it is not recommended to separate different environments into independent ymls, because when docker is mounted, another one needs to be mounted. However, our external documentation always states that the application.yml is mounted. Changing it will cause doubts.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Feb 5, 2024
@zqr10159
Copy link
Member Author

zqr10159 commented Feb 5, 2024

ok

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 5, 2024
@tomsun28 tomsun28 added this to the 1.4.5 milestone Feb 5, 2024
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Feb 5, 2024
@tomsun28 tomsun28 merged commit e97baf9 into apache:master Feb 5, 2024
2 checks passed
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Co-authored-by: tomsun28 <tomsun28@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants