Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support monitor metrics name i18n: ClickHouse #1642

Merged
merged 2 commits into from
Mar 14, 2024
Merged

support monitor metrics name i18n: ClickHouse #1642

merged 2 commits into from
Mar 14, 2024

Conversation

ZY945
Copy link
Member

@ZY945 ZY945 commented Mar 13, 2024

What's changed?

support monitor metrics name i18n:ClickHouse

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@ZY945 ZY945 linked an issue Mar 13, 2024 that may be closed by this pull request
[clickhouse] (https://github.com/dromara/hertzbeat/blob/master/manager/src/main/resources/define/app-clickhouse.yml) #1639
Closed
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Mar 13, 2024
@tomsun28 tomsun28 added this to the 1.5.1 milestone Mar 13, 2024
TJxiaobao
TJxiaobao approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@TJxiaobao TJxiaobao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 good！！！

@tomsun28 tomsun28 merged commit aded3d1 into master Mar 14, 2024
2 checks passed
@ZY945 ZY945 deleted the app-clickhouse-metrics-internation branch March 14, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TJxiaobao TJxiaobao TJxiaobao approved these changes

@tomsun28 tomsun28 Awaiting requested review from tomsun28

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
1.6.0
3 participants
@ZY945 @TJxiaobao @tomsun28