Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix The annotation @Transactional specifies rollbackFor. #1643

Merged
merged 2 commits into from
Mar 17, 2024
Merged

bugfix The annotation @Transactional specifies rollbackFor. #1643

merged 2 commits into from
Mar 17, 2024

Conversation

handy-git
Copy link
Contributor

@handy-git handy-git commented Mar 14, 2024 •
edited

What's changed?

bugfix The annotation @transactional specifies rollbackFor.

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 requested a review from vinci-897 March 14, 2024 02:26
@vinci-897
Copy link
Contributor

vinci-897 commented Mar 15, 2024 •
edited

lgtm👍

@tomsun28
Copy link
Contributor

@all-contributors please add @handy-git for code

@allcontributors allcontributors bot mentioned this pull request Mar 17, 2024
Merged
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers bugfix labels Mar 17, 2024
@tomsun28 tomsun28 added this to the 1.5.1 milestone Mar 17, 2024
@tomsun28 tomsun28 merged commit 49455d5 into apache:master Mar 17, 2024
2 checks passed
@allcontributors AllContributors
Copy link
Contributor

@tomsun28

I've put up a pull request to add @handy-git! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinci-897 vinci-897 vinci-897 approved these changes

Assignees
No one assigned
Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@handy-git @vinci-897 @tomsun28