Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix bug where reopening pop-up window still retained previously edited data after closing. #1698

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

starmilkxin
Copy link
Contributor

fix bug where reopening pop-up window still retained previously edited data after closing.
#1653

What's changed?

This may be due to the failure to reset data objects when the page is closed, such as cascadeValues:

f01cab06d7bc547872da23004c1d0cb

And alertRules:

0d59946ccf7614bc19f39eba09e53c5

Reset it when closing the page, which seems to have resolved the issue for now:

  onManageModalCancel() {
    this.cascadeValues = [];
    this.alertRules = [{}];
    this.isExpr = false;
    this.isManageModalVisible = false;
  }

Edit page:

image

After closing/canceling the page:

image

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers bugfix labels Mar 30, 2024
@tomsun28 tomsun28 added this to the 1.5.1 milestone Mar 30, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

@tomsun28 tomsun28 merged commit 066fb9e into apache:master Mar 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants