Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]Support multiple receivers. #1731

Merged
merged 12 commits into from
Apr 14, 2024
Merged

[Improvement]Support multiple receivers. #1731

merged 12 commits into from
Apr 14, 2024

Conversation

zqr10159
Copy link
Member

@zqr10159 zqr10159 commented Apr 11, 2024 •
edited by tomsun28

What's changed?

[Improvement]Support multiple receivers.
image
image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@zqr10159 zqr10159 requested a review from tomsun28 April 11, 2024 16:05
@tomsun28 tomsun28 linked an issue Apr 12, 2024 that may be closed by this pull request
[Task] <Notification policy acceptance object supports multiple selection> #1728
Closed
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature labels Apr 12, 2024
tomsun28
tomsun28 reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomsun28 tomsun28 requested a review from Ceilzcx April 13, 2024 14:37
tomsun28
tomsun28 approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomsun28 tomsun28 merged commit 97f27b4 into master Apr 14, 2024
3 checks passed
@tomsun28
Copy link
Contributor

tomsun28 commented Apr 14, 2024 •
edited by zqr10159

hi, the bot check license header error.

INFO Totally checked 1977 files, valid: 852, invalid: 2, ignored: 1123, fixed: 0 
ERROR the following files don't have a valid license header: 
common/src/main/java/org/apache/hertzbeat/common/entity/manager/JsonLongListAttributeConverter.java
common/src/main/java/org/apache/hertzbeat/common/entity/manager/JsonStringListAttributeConverter.java 
ERROR one or more files does not have a valid license header 
Error: Process completed with exit code 1.

@zqr10159
Copy link
Member Author

hi, the bot check license header error.


INFO Totally checked 1977 files, valid: 852, invalid: 2, ignored: 1123, fixed: 0 

ERROR the following files don't have a valid license header: 

common/src/main/java/org/apache/hertzbeat/common/entity/manager/JsonLongListAttributeConverter.java

common/src/main/java/org/apache/hertzbeat/common/entity/manager/JsonStringListAttributeConverter.java 

ERROR one or more files does not have a valid license header 

Error: Process completed with exit code 1.

I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

@Ceilzcx Ceilzcx Awaiting requested review from Ceilzcx

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] <Notification policy acceptance object supports multiple selection>
2 participants
@zqr10159 @tomsun28