Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unlicensed dependency 'wolfy87 eventemitter' #1745

Merged
merged 3 commits into from
Apr 15, 2024
Merged

remove unlicensed dependency 'wolfy87 eventemitter' #1745

merged 3 commits into from
Apr 15, 2024

Conversation

alpha951
Copy link
Contributor

@alpha951 alpha951 commented Apr 14, 2024 •
edited

What's changed?

  • Removed the unused @delon/chart package which was using unlicensed wolfy87-eventemitter dependency.
  • Removed unused import of @delon/chart/index from style.less
  • Update LICENSE

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@alpha951 alpha951 changed the title Task remove dependency 'wolfy87 eventemitter remove dependency 'wolfy87 eventemitter Apr 14, 2024
@alpha951 alpha951 changed the title remove dependency 'wolfy87 eventemitter remove unlicensed dependency 'wolfy87 eventemitter' Apr 14, 2024
@alpha951 alpha951 mentioned this pull request Apr 14, 2024
Closed
2 tasks
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Apr 15, 2024
@tomsun28 tomsun28 linked an issue Apr 15, 2024 that may be closed by this pull request
[Task] <remove the unlicense dependency wolfy87-eventemitter in frontend web-app> #1739
Closed
2 tasks
tomsun28
tomsun28 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

@tomsun28 tomsun28 merged commit b3a869d into apache:master Apr 15, 2024
1 check passed
@alpha951 alpha951 deleted the task-remove-dependency-wolfy87-eventemitter branch April 15, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] <remove the unlicense dependency wolfy87-eventemitter in frontend web-app>
3 participants
@alpha951 @tomsun28 @fm-keshavcarpenter