[refactor] method improvement rationale #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsun28
added
enhancement
tomsun28
changed the title
tomsun28
reviewed
Apr 17, 2024
collector/src/main/java/org/apache/hertzbeat/collector/util/CollectUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Hyeon Sung <gorae930301@gmail.com>
|
Thanks!! @TJxiaobao !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
The improved method below utilizes the StringUtils.isAnyEmpty() method from the Apache Commons Lang library to enhance readability and maintainability. This change improves code conciseness and clarity while reducing repetitive null and empty string checks. Moreover, using these utility methods makes the code's intent clearer and decreases the likelihood of errors.
Checklist
Add or update API