Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated methods with builder pattern for RedisURI construction #1772

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

dukbong
Copy link
Contributor

@dukbong dukbong commented Apr 18, 2024

What's changed?

  • Replaced the deprecated methods in RedisCommonCollectImpl with the builder pattern for RedisURI creation. This enhancement improves the maintainability and extensibility of the code.
  • Eliminated unnecessary string object allocations and enhanced readability using forEach and lambda expressions. This leads to code simplification and improved comprehension.
  • Improved readability by using StringUtils.isAnyEmpty() method. This helps clarify the intent of the code and prevents potential bugs.

These three changes enhance the quality of the code, allowing for better maintainability and extensibility.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zqr10159 zqr10159 merged commit 4627fb5 into apache:master Apr 18, 2024
3 checks passed
@dukbong dukbong deleted the reduce branch April 18, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants