Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove and translate chinese to english in collector,script,push,remoting and manager module #1774

Merged
merged 18 commits into from
Apr 18, 2024

Conversation

MananPoojara
Copy link
Contributor

@MananPoojara MananPoojara commented Apr 18, 2024

What's changed?

i remove and translate chinese to english in below module #1759
collector
script
push
remoting
manager
if there is something remaining let me know

Translated all Chinese language comments to English in the targeted modules.
Replaced Chinese language text with equivalent English text in specified areas of the codebase.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.
  • remove and translate chinese to english in module collector
  • remove and translate chinese to english in module script
  • remove and translate chinese to english in module push
  • remove and translate chinese to english in module remoting
  • remove and translate chinese to english in module manager

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Manan Pujara <104253184+MananPoojara@users.noreply.github.com>
Signed-off-by: Logic <zqr10159@dromara.org>
Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zqr10159 zqr10159 merged commit 7d5082f into apache:master Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants