Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Improve the import checkstyle #1802

Merged
merged 3 commits into from
Apr 21, 2024

Conversation

crossoverJie
Copy link
Contributor

@crossoverJie crossoverJie commented Apr 21, 2024

What's changed?

Add some import check.

  • RedundantImport
  • ImportOrder
  • AvoidStarImport
  • RedundantModifier
  • UnusedImports

It can make the source code more standardized and unified.

Most of them are imported code modifications, and the e2e test is used to assure the correctness of the code.

Refer to this to this link: https://github.com/apache/pulsar/blob/21647a1fc69ff46e65b6eaa37dd6d435e9f8eaef/buildtools/src/main/resources/pulsar/checkstyle.xml#L111-L115

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added the docs label Apr 21, 2024
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 21, 2024
@tomsun28 tomsun28 self-requested a review April 21, 2024 07:47
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍👍

@tomsun28 tomsun28 merged commit 6f942bc into apache:master Apr 21, 2024
3 checks passed
@crossoverJie crossoverJie deleted the improve-checkstyle branch April 21, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants