Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Add Apache Hbase RegionServer monitoring #1833

Merged
merged 6 commits into from
Apr 25, 2024
Merged

[feature] Add Apache Hbase RegionServer monitoring #1833

merged 6 commits into from
Apr 25, 2024

Conversation

zhangshenghang
Copy link
Contributor

@zhangshenghang zhangshenghang commented Apr 24, 2024 •
edited

What's changed?

#1822

  • Add Apache Hbase RegionServer monitoring
  • Add Apache Hbase RegionServer monitoring documentation

Checklist

@github-actions github-actions bot added doc Improvements or additions to documentation monitoring-template backend labels Apr 24, 2024
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 24, 2024
@tomsun28
Copy link
Contributor

LGTM! Btw, we can edit here to add helo doc menu. https://github.com/apache/hertzbeat/blob/master/home/sidebars.json#L215

tomsun28
tomsun28 previously approved these changes Apr 24, 2024
View reviewed changes
@zhangshenghang
Copy link
Contributor Author

LGTM！顺便说一句，我们可以在这里编辑以添加 helo 文档菜单。https://github.com/apache/hertzbeat/blob/master/home/sidebars.json#L215

okey

@zhangshenghang
Copy link
Contributor Author

LGTM! Btw, we can edit here to add helo doc menu. https://github.com/apache/hertzbeat/blob/master/home/sidebars.json#L215

Sidebars have been updated @tomsun28

tomsun28
tomsun28 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

@tomsun28 tomsun28 merged commit 4a3e273 into apache:master Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend doc Improvements or additions to documentation good first pull request Good for newcomers monitoring-template
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhangshenghang @tomsun28