Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] support use ngql query metrics from nebulaGraph #1917

Merged
merged 6 commits into from
May 5, 2024
Merged

[feature] support use ngql query metrics from nebulaGraph #1917

merged 6 commits into from
May 5, 2024

Conversation

LiuTianyou
Copy link
Contributor

@LiuTianyou LiuTianyou commented May 5, 2024 •
edited

What's changed?

  1. support use ngql query metrics from nebulaGraph [Task] Supports querying metrics from nebula Graph using NGQL #1869
  2. add NebulaGraph cluster monitoring template
    nebulaGraph_cluster_1
    nebulaGraph_cluster_2

I will add documents in the next PR

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 5, 2024
@tomsun28
Copy link
Contributor

tomsun28 commented May 5, 2024

👍LGTM
Please update the license here https://github.com/apache/hertzbeat/blob/master/material/licenses/backend/LICENSE#L415 , add https://mvnrepository.com/artifact/com.vesoft/client/3.6.0 in apache2

tomsun28
tomsun28 approved these changes May 5, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!👍👍

@tomsun28 tomsun28 linked an issue May 5, 2024 that may be closed by this pull request
[Task] Supports querying metrics from nebula Graph using NGQL #1869
Closed
2 tasks
@tomsun28 tomsun28 merged commit d8887da into apache:master May 5, 2024
3 checks passed
@LiuTianyou LiuTianyou deleted the ngql-metrics branch May 7, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend collector good first pull request Good for newcomers license monitoring-template new feature
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Supports querying metrics from nebula Graph using NGQL
2 participants
@LiuTianyou @tomsun28