Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve] add filename check in home ci #2049

Merged
merged 4 commits into from
May 30, 2024
Merged

[improve] add filename check in home ci #2049

merged 4 commits into from
May 30, 2024

Conversation

LiuTianyou
Copy link
Contributor

What's changed?

  1. add filename check in home ci
  2. modify the contribution guide for the document

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added doc Improvements or additions to documentation infra labels May 29, 2024
tomsun28
tomsun28 approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tomsun28 tomsun28 merged commit f602bec into apache:master May 30, 2024
4 checks passed
@LiuTianyou LiuTianyou deleted the filename-check-ci branch June 24, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
doc Improvements or additions to documentation infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LiuTianyou @tomsun28