Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix deleting component error #2152

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

LiuTianyou
Copy link
Contributor

What's changed?

  1. fix deleting component error about ([BUG] Deleting the component associated with the event prompts an error #2147)
  2. add i18n support to backend services

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@LiuTianyou LiuTianyou changed the title [fix] fix deleting component error [bugfix] fix deleting component error Jun 27, 2024
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Jun 27, 2024
@zqr10159 zqr10159 merged commit c06f53c into apache:master Jun 27, 2024
3 checks passed
@tomsun28
Copy link
Contributor

Hi, there's onething we need to discuss. Whether we need to use i18n errors and data in the restful api response, before only in the user-facing level in the webapp to show i18n message, for the developer-facing api layer directly use the English message due we think english notice message for developers is enough.

@LiuTianyou
Copy link
Contributor Author

Hi, there's onething we need to discuss. Whether we need to use i18n errors and data in the restful api response, before only in the user-facing level in the webapp to show i18n message, for the developer-facing api layer directly use the English message due we think english notice message for developers is enough.

Got it, I will remove the i18n information returned by the API and use English error messages to keep it consistent with the current design.

@LiuTianyou LiuTianyou deleted the fix-2147 branch June 29, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants