refac: rename method append

apache · Jul 12, 2022 · 0c291c4 · 0c291c4
1 parent 7d7fd1a
commit 0c291c4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java b/ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java
@@ -141,7 +141,7 @@ WHEN NOT MATCHED THEN INSERT VALUES (source.a2, source.b2)
     String subQueryAlias = isAliased(targetNameNode) ? targetName : targetTable.getTTable().getTableName();
     ColumnAppender columnAppender = nonNativeAcid ? new NonNativeAcidColumnAppender(targetTable, conf, subQueryAlias) :
             new NativeAcidColumnAppender(targetTable, conf, subQueryAlias);
-    columnAppender.append(rewrittenQueryStr, Context.Operation.UPDATE);
+    columnAppender.appendAcidSelectColumns(rewrittenQueryStr, Context.Operation.UPDATE);
 
     rewrittenQueryStr.deleteCharAt(rewrittenQueryStr.length() - 1); // remove last ','
     addColsToSelect(targetTable.getCols(), rewrittenQueryStr);

diff --git a/ql/src/java/org/apache/hadoop/hive/ql/parse/RewriteSemanticAnalyzer.java b/ql/src/java/org/apache/hadoop/hive/ql/parse/RewriteSemanticAnalyzer.java
@@ -617,7 +617,7 @@ protected String getMatchedText(ASTNode n) {
   public static final String SUB_QUERY_ALIAS = "s";
 
   protected interface ColumnAppender {
-    void append(StringBuilder stringBuilder, Context.Operation operation);
+    void appendAcidSelectColumns(StringBuilder stringBuilder, Context.Operation operation);
     List<String> getDeleteValues(Context.Operation operation);
     List<String> getSortKeys();
   }
@@ -635,7 +635,7 @@ public NativeAcidColumnAppender(Table table, HiveConf conf, String subQueryAlias
     }
 
     @Override
-    public void append(StringBuilder stringBuilder, Context.Operation operation) {
+    public void appendAcidSelectColumns(StringBuilder stringBuilder, Context.Operation operation) {
       stringBuilder.append("ROW__ID,");
       for (FieldSchema fieldSchema : table.getPartCols()) {
         String identifier = HiveUtils.unparseIdentifier(fieldSchema.getName(), this.conf);
@@ -673,7 +673,7 @@ public NonNativeAcidColumnAppender(Table table, HiveConf conf, String subQueryAl
     }
 
     @Override
-    public void append(StringBuilder stringBuilder, Context.Operation operation) {
+    public void appendAcidSelectColumns(StringBuilder stringBuilder, Context.Operation operation) {
       List<FieldSchema> acidSelectColumns = table.getStorageHandler().acidSelectColumns(table, operation);
       for (FieldSchema fieldSchema : acidSelectColumns) {
         String identifier = HiveUtils.unparseIdentifier(fieldSchema.getName(), this.conf);

diff --git a/ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java b/ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java
@@ -282,7 +282,7 @@ private void analyzeSplitUpdate(ASTNode tree, Table mTable, ASTNode tabNameNode)
     boolean nonNativeAcid = AcidUtils.isNonNativeAcidTable(mTable);
     ColumnAppender columnAppender = nonNativeAcid ? new NonNativeAcidColumnAppender(mTable, conf, SUB_QUERY_ALIAS) :
             new NativeAcidColumnAppender(mTable, conf, SUB_QUERY_ALIAS);
-    columnAppender.append(rewrittenQueryStr, operation);
+    columnAppender.appendAcidSelectColumns(rewrittenQueryStr, operation);
     List<String> deleteValues = columnAppender.getDeleteValues(operation);
     int columnOffset = deleteValues.size();