Skip to content

Commit

Permalink
remove unused parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
kasakrisz committed Jul 14, 2022
1 parent 6d732d9 commit a65a2ae
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ WHEN NOT MATCHED THEN INSERT VALUES (source.a2, source.b2)
break;
case HiveParser.TOK_DELETE:
numWhenMatchedDeleteClauses++;
String s1 = handleDelete(whenClause, rewrittenQueryStr, targetNameNode,
String s1 = handleDelete(whenClause, rewrittenQueryStr,
onClauseAsText, extraPredicate, hintProcessed ? null : hintStr, false, columnAppender);
hintProcessed = true;
if (numWhenMatchedUpdateClauses + numWhenMatchedDeleteClauses == 1) {
Expand Down Expand Up @@ -433,7 +433,7 @@ private String handleUpdate(ASTNode whenMatchedUpdateClause, StringBuilder rewri
* by this call to handleDelete()
*/
rewrittenQueryStr.append(" -- update clause (delete part)\n");
handleDelete(whenMatchedUpdateClause, rewrittenQueryStr, target, onClauseAsString,
handleDelete(whenMatchedUpdateClause, rewrittenQueryStr, onClauseAsString,
deleteExtraPredicate, hintStr, true, columnAppender);
}

Expand All @@ -445,8 +445,8 @@ private String handleUpdate(ASTNode whenMatchedUpdateClause, StringBuilder rewri
* @param updateExtraPredicate - see notes at caller
*/
private String handleDelete(ASTNode whenMatchedDeleteClause, StringBuilder rewrittenQueryStr,
ASTNode target, String onClauseAsString, String updateExtraPredicate,
String hintStr, boolean splitUpdateEarly, ColumnAppender columnAppender) throws SemanticException {
String onClauseAsString, String updateExtraPredicate,
String hintStr, boolean splitUpdateEarly, ColumnAppender columnAppender) {
assert whenMatchedDeleteClause.getType() == HiveParser.TOK_MATCHED;
assert (splitUpdateEarly &&
getWhenClauseOperation(whenMatchedDeleteClause).getType() == HiveParser.TOK_UPDATE) ||
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ protected void analyze(ASTNode tree, Table table, ASTNode tabNameNode) throws Se

private void analyzeUpdate(ASTNode tree, Table mTable, ASTNode tabNameNode) throws SemanticException {
operation = Context.Operation.UPDATE;
boolean nonNativeAcid = AcidUtils.isNonNativeAcidTable(mTable);

if (HiveConf.getBoolVar(queryState.getConf(), HiveConf.ConfVars.SPLIT_UPDATE)) {
analyzeSplitUpdate(tree, mTable, tabNameNode);
} else {
Expand Down

0 comments on commit a65a2ae

Please sign in to comment.