Skip to content

Commit

Permalink
HIVE-28100: Fix Some Typos in CachedStore. (#5109)(Shilun Fan, review…
Browse files Browse the repository at this point in the history
…ed by Butao Zhang)
  • Loading branch information
slfan1989 committed Mar 7, 2024
1 parent f4e4114 commit bee33d2
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1543,7 +1543,7 @@ public Table getTable(String catName, String dbName, String tblName, String vali
}

@Override public List<Table> getAllMaterializedViewObjectsForRewriting(String catName) throws MetaException {
// TODO fucntionCache
// TODO functionCache
return rawStore.getAllMaterializedViewObjectsForRewriting(catName);
}

Expand Down Expand Up @@ -2574,34 +2574,34 @@ long getPartsFound() {
}

@Override public void createFunction(Function func) throws InvalidObjectException, MetaException {
// TODO fucntionCache
// TODO functionCache
rawStore.createFunction(func);
}

@Override public void alterFunction(String catName, String dbName, String funcName, Function newFunction)
throws InvalidObjectException, MetaException {
// TODO fucntionCache
// TODO functionCache
rawStore.alterFunction(catName, dbName, funcName, newFunction);
}

@Override public void dropFunction(String catName, String dbName, String funcName)
throws MetaException, NoSuchObjectException, InvalidObjectException, InvalidInputException {
// TODO fucntionCache
// TODO functionCache
rawStore.dropFunction(catName, dbName, funcName);
}

@Override public Function getFunction(String catName, String dbName, String funcName) throws MetaException {
// TODO fucntionCache
// TODO functionCache
return rawStore.getFunction(catName, dbName, funcName);
}

@Override public List<Function> getAllFunctions(String catName) throws MetaException {
// TODO fucntionCache
// TODO functionCache
return rawStore.getAllFunctions(catName);
}

@Override public List<String> getFunctions(String catName, String dbName, String pattern) throws MetaException {
// TODO fucntionCache
// TODO functionCache
return rawStore.getFunctions(catName, dbName, pattern);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ void refreshTableWrapperInCache(String tblKey) {
public void setConcurrencyLevel(int cl){
this.concurrencyLevel = cl;
}
//number of miliseconds between size updates.
//number of milliseconds between size updates.
public void setRefreshInterval(int interval){
this.refreshInterval = interval;
}
Expand Down Expand Up @@ -519,7 +519,7 @@ && cacheConstraints(constraints.getNotNullConstraints(), fromPrewarm, MemberName
/**
* Common method to cache constraints
* @param constraintsList list of constraints to add to cache
* @param fromPrewarm is this method called as part of perwarm phase
* @param fromPrewarm is this method called as part of prewarm phase
* @param mn Constraint type
* @return memory constraint is handled by cache eviction policy hence this method will always return true
* if correct constraint type is provided.
Expand Down Expand Up @@ -1519,7 +1519,7 @@ public void populateCatalogsInCache(Collection<Catalog> catalogs) {
cacheLock.writeLock().lock();
// Since we allow write operations on cache while prewarm is happening:
// 1. Don't add databases that were deleted while we were preparing list for prewarm
// 2. Skip overwriting exisiting db object
// 2. Skip overwriting existing db object
// (which is present because it was added after prewarm started)
if (catalogsDeletedDuringPrewarm.contains(catCopy.getName())) {
continue;
Expand Down Expand Up @@ -1622,7 +1622,7 @@ public void populateDatabasesInCache(List<Database> databases) {
cacheLock.writeLock().lock();
// Since we allow write operations on cache while prewarm is happening:
// 1. Don't add databases that were deleted while we were preparing list for prewarm
// 2. Skip overwriting exisiting db object
// 2. Skip overwriting existing db object
// (which is present because it was added after prewarm started)
String key = CacheUtils.buildDbKey(dbCopy.getCatalogName().toLowerCase(), dbCopy.getName().toLowerCase());
if (databasesDeletedDuringPrewarm.contains(key)) {
Expand Down Expand Up @@ -2707,7 +2707,7 @@ Map<ByteArrayWrapper, StorageDescriptorWrapper> getSdCache() {
}

/**
* This resets the contents of the cataog cache so that we can re-fill it in another test.
* This resets the contents of the catalog cache so that we can re-fill it in another test.
*/
void resetCatalogCache() {
isCatalogCachePrewarmed = false;
Expand Down

0 comments on commit bee33d2

Please sign in to comment.