HIVE-23462 rewrite cume_dist #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
jcamachor
reviewed
Jun 8, 2020
| @@ -392,10 +392,11 @@ private static String getName(GenericUDF hiveUDF) { | |||
| registerFunction("istrue", SqlStdOperatorTable.IS_TRUE, hToken(HiveParser.Identifier, "istrue")); | |||
| registerFunction("isnotfalse", SqlStdOperatorTable.IS_NOT_FALSE, hToken(HiveParser.Identifier, "isnotfalse")); | |||
| registerFunction("isfalse", SqlStdOperatorTable.IS_FALSE, hToken(HiveParser.Identifier, "isfalse")); | |||
| registerFunction("is not distinct from", SqlStdOperatorTable.IS_NOT_DISTINCT_FROM, hToken(HiveParser.EQUAL_NS, "<=>")); | |||
There was a problem hiding this comment.
Just to confirm, does this mean that is not distinct from was never used?
There was a problem hiding this comment.
the calcite2hive translation was not working - and thrown an exception
I'm not sure about hive2calcite ; I've made a note on HIVE-23594 to check out what was happening
jcamachor
reviewed
Jun 8, 2020
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
abstractdog
pushed a commit
to abstractdog/hive
that referenced
this pull request
Apr 9, 2021
…everal commits + CDPD-13544) HIVE-22970: Add a qoption to enable tests to use transactional mode (Zoltan Haindrich reviewed by Peter Vary) HIVE-22940: Make the datasketches functions available as predefined functions (Zoltan Haindrich reviewed by Jesus Camacho Rodriguez) HIVE-23030: Enable sketch union-s to be rolled up (Zoltan Haindrich reviewed by Jesus Camacho Rodriguez) HIVE-23031: Add option to enable transparent rewrite of count(distinct) into sketch functions (Zoltan Haindrich reviewed by Jesus Camacho Rodriguez) HIVE-23368: MV rebuild should produce the same view as the one configured at creation time (Zoltan Haindrich reviewed by Jesus Camacho Rodriguez) HIVE-23434: Add option to rewrite PERCENTILE_DISC to sketch functions (Zoltan Haindrich reviewed by Jesus Camacho Rodriguez) HIVE-16255: Support percentile_cont / percentile_disc (Laszlo Bodor via Zoltan Haindrich) HIVE-23460: Add qoption to disable qtests (Zoltan Haindrich reviewed by László Bodor, Miklos Gergely) HIVE-23462: Add option to rewrite CUME_DIST to sketch functions (apache#1031) HIVE-23598: Add option to rewrite NTILE and RANK to sketch functions (apache#1126) HIVE-21449: Implement 'WITHIN GROUP' clause (Krisztian Kasa, reviewed by Jesus Camacho Rodriguez) HIVE-22250: Describe function does not provide description for rank functions (Krisztian Kasa reviewed by Jesus Camacho Rodriguez) HIVE-22240: Function percentile_cont fails when array parameter passed (Krisztian Kasa, reviewed by Jesus Camacho Rodriguez) HIVE-22292: Implement Hypothetical-Set Aggregate Functions (Krisztian Kasa, reviewed by Jesus Camacho Rodriguez) HIVE-23275: Represent UNBOUNDED in window functions in CBO correctly (Jesus Camacho Rodriguez, reviewed by Zoltan Haindrich) HIVE-22126: hive-exec packaging should shade guava (Eugene Chung via Ádám Szita, Zoltan Haindrich) HIVE-23790: The error message length of 2000 is exceeded for scheduled query (Zoltan Haindrich reviewed by Jesus Camacho Rodriguez) HIVE-22621: unstable testcase: TestLlapSignerImpl.testSigning disable TestJdbcGenericUDTFGetSplits test HIVE-23396: Many fixes and improvements to stabilize tests (Zoltan Haindrich reviewed by Miklos Gergely) HIVE-23827: Upgrade to DataSketches 1.1.0 (apache#1233) (Zoltan Haindrich via Denys Kuzmenko) CDPD-13544 HIVE-22301: Hive lineage is not generated for insert overwrite queries on partitioned tables (Zoltan Haindrich reviewed by Denys Kuzmenko and Jesus Camacho Rodriguez) Change-Id: I1a26a90096fc706f241ab501088e34b3d5600372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.