Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-23620: Moving to SpotBugs that is actively maintained #1066

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

pgaref
Copy link
Contributor

@pgaref pgaref commented Jun 5, 2020

Change-Id: I54ca2e805732692784d64d7d05004e1866fcc815

@pgaref
Copy link
Contributor Author

pgaref commented Jun 5, 2020

Thoughts here? @kgyrtkirk @abstractdog

@kgyrtkirk
Copy link
Member

cool!
perfectly makes sense to me; but let's wait when we don't use the ptest server anymore - this might affect it

@kgyrtkirk
Copy link
Member

ptest is disabled, I think we can get this in; however I've just merged #1069...does this need any jenkinsfile changes?

@pgaref
Copy link
Contributor Author

pgaref commented Jun 11, 2020

ptest is disabled, I think we can get this in; however I've just merged #1069...does this need any jenkinsfile changes?

Hey @kgyrtkirk -- yes we will need to use spotbugs syntax instead in the precheck, let me update the PR and test.

In the meanwhile, I also added storage-api to the check list so #1063 can also be now pushed.

Panos Garefalakis added 2 commits June 12, 2020 10:53
Change-Id: I54ca2e805732692784d64d7d05004e1866fcc815
Change-Id: I680ea0bd48f410467e891142a1368ead82d0c742
@pgaref
Copy link
Contributor Author

pgaref commented Jun 12, 2020

ptest is disabled, I think we can get this in; however I've just merged #1069...does this need any jenkinsfile changes?

Hey @kgyrtkirk -- yes we will need to use spotbugs syntax instead in the precheck, let me update the PR and test.

In the meanwhile, I also added storage-api to the check list so #1063 can also be now pushed.

Updated, waiting for a clean run

@kgyrtkirk kgyrtkirk merged commit 5120f4f into apache:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants