Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-23704: Decode Base-64 String from HTTP Header #1127

Merged
merged 2 commits into from Jun 21, 2020
Merged

HIVE-23704: Decode Base-64 String from HTTP Header #1127

merged 2 commits into from Jun 21, 2020

Conversation

belugabehr
Copy link
Contributor

No description provided.

@belugabehr belugabehr closed this Jun 16, 2020
@belugabehr belugabehr reopened this Jun 16, 2020
@belugabehr
Copy link
Contributor Author

belugabehr commented Jun 17, 2020 •
edited

Existing code works because Commons Digest Base64 implementation ignores invalid characters:.

https://github.com/apache/commons-codec/blob/41c6f486fd4f5c2450c9311c40dbbf7e576d2907/src/main/java/org/apache/commons/codec/binary/Base64.java#L621

@belugabehr belugabehr closed this Jun 18, 2020
@belugabehr belugabehr reopened this Jun 18, 2020
@belugabehr
Copy link
Contributor Author

+1 via Ashutosh Chauhan

https://issues.apache.org/jira/browse/HIVE-23704?focusedCommentId=17140851&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17140851

@belugabehr belugabehr merged commit 4c18dbb into apache:master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgyrtkirk kgyrtkirk Awaiting requested review from kgyrtkirk

@miklosgergely miklosgergely Awaiting requested review from miklosgergely

@pvary pvary Awaiting requested review from pvary

Assignees
No one assigned
Labels
tests passed
Projects
None yet
Milestone
No milestone
2 participants
@belugabehr @kgyrtkirk