Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-23467: Add a skip.trash config for HMS to skip trash when deleti… #1133

Closed
wants to merge 2 commits into from
Closed

HIVE-23467: Add a skip.trash config for HMS to skip trash when deleti… #1133

wants to merge 2 commits into from

Conversation

hsnusonic
Copy link
Contributor

…ng external table data

@nrg4878
Copy link
Contributor

nrg4878 commented Jun 17, 2020

so if the goal is to deprecate "external.table.purge" going forward in favor of "external.table.autodelete", can we remove all the current references in the code as well and convert them to the new property. so all the new tables should be creating using the new property.

sam-an-cloudera
sam-an-cloudera reviewed Jun 17, 2020
View reviewed changes
Copy link
Contributor

@sam-an-cloudera sam-an-cloudera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final idea was to just add skip.trash at the table properties level, and not adding alias for external.table.purge.

...re/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java Outdated
@@ -105,6 +105,7 @@ protected DateFormat initialValue() {
public static final String DB_EMPTY_MARKER = "!";

public static final String EXTERNAL_TABLE_PURGE = "external.table.purge";
public static final String EXTERNAL_TABLE_AUTODELETE = "external.table.autodelete";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion with @nrg4878 and @thejasmn , we thought it's best that we don't add this new option because "external.table.purge" is widely used. Introducing the new autodelete might cause confusion.

@hsnusonic
Give up external.table.autodelete
65f902d 
Change some existing auto.purge to skip.trash
nrg4878
nrg4878 approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@nrg4878 nrg4878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. +1 for me.

@nrg4878
Copy link
Contributor

nrg4878 commented Jun 25, 2020

This fix has been committed to master for 4.0.0 release. This can be closed out.

@hsnusonic hsnusonic closed this Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrg4878 nrg4878 nrg4878 approved these changes

@sam-an-cloudera sam-an-cloudera sam-an-cloudera approved these changes

Assignees
No one assigned
Labels
tests passed
Projects
None yet
Milestone
No milestone
4 participants
@hsnusonic @nrg4878 @sam-an-cloudera @kgyrtkirk