HIVE-23715: Fix zookeeper ssl keystore password handling issues #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvary
reviewed
Jun 18, 2020
| + " or " | ||
| + MetastoreDelegationTokenManager.DELEGATION_TOKEN_STORE_ZK_CONNECT_STR_ALTERNATE | ||
| + WHEN_ZK_DSTORE_MSG); | ||
| throw new IllegalArgumentException("Zookeeper connect string has to be specified through " + "either " |
There was a problem hiding this comment.
Could you please remove extra concatenation of strings?
pvary
reviewed
Jun 18, 2020
| zkConnectPort = MetastoreConf.getVar(conf, MetastoreConf.ConfVars.THRIFT_ZOOKEEPER_CLIENT_PORT); | ||
| connectTimeoutMillis = (int) MetastoreConf | ||
| .getTimeVar(conf, MetastoreConf.ConfVars.THRIFT_ZOOKEEPER_CONNECTION_TIMEOUT, TimeUnit.MILLISECONDS); | ||
| sslEnabled = MetastoreConf.getBoolVar(conf, MetastoreConf.ConfVars.THRIFT_ZOOKEEPER_SSL_ENABLE); |
There was a problem hiding this comment.
This is a bit awkward: if (sslEnabled) {} else {sslEnabled=..., if (sslEnabled)...}
There was a problem hiding this comment.
That else is for the previous if statement.
if (we use the alternate config)
read the alternate sslEnabled
if( that property is set)
read the other properties from the alternate config
else // we use the delegation own config
read the delagation sslEnabled config
if (the that property is set)
read the other properties from the delegation config
|
close and reopen to rerun travis build |
pvary
approved these changes
Jun 18, 2020
kgyrtkirk
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
abstractdog
pushed a commit
to abstractdog/hive
that referenced
this pull request
Apr 9, 2021
…g issues (Peter Varga reviewed by Peter Vary) Closes apache#1141 (cherry picked from commit 439956d) Change-Id: I584b7344649e7d8eeec2aa2a29777ba6a2e7cfcc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIVE-23715: Fix zookeeper ssl keystore password handling issues